Existing language server instances with different root_dirs are reused, out of accordance with lspconfig's documentation

[andrewbraxton]

Description

This is essentially a duplicate of #2967 which was incorrectly closed (lspconfig does indeed manage launching of servers.).

The help docs for lspconfig say:

nvim-lspconfig/doc/lspconfig.txt

Lines 62 to 63 in 57154fd

	If a root directory (string) is returned which is unique from any previously
	returned root_dir, a new server will be spawned with that root directory.

But this is not the case. See the following code which causes existing language servers with the same name to be reused.

nvim-lspconfig/lua/lspconfig/manager.lua

Lines 133 to 136 in 57154fd

	reuse_client = function(existing_client)
	if (self._clients[root_dir] or {})[existing_client.name] then
	self:_notify_workspace_folder_added(root_dir, existing_client)
	return true

Either the code should be updated to match the docs, or the docs should be corrected and a new flag should be added to indicate that unique root dirs should always launch new language server instances. I am happy to try out a PR if the maintainers have a preference for either of those solutions.

[justinmk]

Please try latest Nvim 0.11 from https://github.com/neovim/neovim/releases , using the vim.lsp.config feature. neovim/neovim#31565 seems related, and should give a hint about where the relevant code lives.

The "manager" part of nvim-lspconfig is deprecated #3494 in favor of the vim.lsp.config feature in Nvim core. It will be helpful if you can confirm whether the vim.lsp.config behavior is as you expected.

[andrewbraxton]

I'm using nightly, and yes, the vim.lsp.config behavior in Neovim core does work as expected. I didn't know the manager portion was slated for deprecation (though that makes sense given the additions to core), so feel free to close if manager-related bugs are a wont-fix.

[rcurran1221]

Having the same issue, if I upgrade to 0.11, my issue will be resolved? Or will I need to change config as well? Thanks!

[andrewbraxton]

You'll have to change your config. I don't believe lspconfig provides a way to override reuse_client, so I recommend moving to the vim.lsp.enable() scheme which gives you much more control.

[rcurran1221]

  local client_id = lsp.start(new_config, {
    bufnr = bufnr,
    silent = silent,
    reuse_client = function(existing_client)
      print('reuse client?')
      print(existing_client.root_dir)
      print(root_dir)
      if existing_client.root_dir ~= root_dir then
        print('using new client...')
        return false
      end
      if (self._clients[root_dir] or {})[existing_client.name] then
        self:_notify_workspace_folder_added(root_dir, existing_client)
        return true
      end

      for _, dir_clients in pairs(self._clients) do
        if dir_clients[existing_client.name] then
          self:_notify_workspace_folder_added(root_dir, existing_client)
          return true
        end
      end

      return false
    end,
  })

work around if anyone is looking for one..