Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement assetconfiguration endpoint #4300

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: Implement assetconfiguration endpoint #4300

wants to merge 3 commits into from

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Dec 2, 2024 •
edited
Loading

Fix #4276

  • Filter templates for supported (odp/otp)
  • Add ETag support to the endpoints (handle If-None-Match header)
  • Add tests
  • In addition to the endpoint we can pass the aggregated list of templates along with the same mechanism as feat(settings): add admin & user setting iframe #4373

Possible followup

  • Cleanup old font settings endpoints (move to the new controller and mark as deprecated)

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@juliusknorr juliusknorr requested a review from elzody as a code owner December 2, 2024 16:16
@juliusknorr juliusknorr mentioned this pull request Dec 2, 2024
Open
@juliusknorr juliusknorr marked this pull request as draft December 2, 2024 16:18
@juliusknorr juliusknorr added enhancement New feature or request 2. developing Work in progress labels Dec 2, 2024
@juliusknorr juliusknorr force-pushed the feat/assetconfiguration branch from 71074d4 to 09bf622 Compare February 4, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elzody elzody Awaiting requested review from elzody elzody is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
2. developing Work in progress enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Impress: Make master slides import from templates folder available for use in the sidebar
1 participant
@juliusknorr