From a5875265a128942c83823b9a81772215e164a2f2 Mon Sep 17 00:00:00 2001 From: Ravi Sawlani Date: Wed, 15 Nov 2023 14:08:36 +0530 Subject: [PATCH] enable parallelism on any selenium host (#3956) --- lib/runner/cli/cli.js | 4 ++-- test/src/runner/cli/testCliRunnerParallel.js | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/runner/cli/cli.js b/lib/runner/cli/cli.js index 502bae1a89..1afb670120 100644 --- a/lib/runner/cli/cli.js +++ b/lib/runner/cli/cli.js @@ -446,7 +446,7 @@ class CliRunner { usingServer(test_settings = {}) { // TODO: selenium_host and seleniumHost are for backwards compatability. // remove these in future versions. - return test_settings.selenium?.host || test_settings.selenium_host || test_settings.seleniumHost; + return Utils.isObject(test_settings.selenium) || test_settings.selenium_host || test_settings.seleniumHost; } isTestWorkersEnabled() { @@ -464,7 +464,7 @@ class CliRunner { const {webdriver = {}} = this.testEnvSettings[env]; const desiredCapabilities = this.testEnvSettings[env].capabilities || this.testEnvSettings[env].desiredCapabilities; - if (isMobile(desiredCapabilities) && this.usingServer(this.testEnvSettings[env])) { + if (isMobile(desiredCapabilities) && !this.usingServer(this.testEnvSettings[env])) { if (Concurrency.isWorker()) { Logger.info('Disabling parallelism while running tests on mobile platform'); diff --git a/test/src/runner/cli/testCliRunnerParallel.js b/test/src/runner/cli/testCliRunnerParallel.js index 186c5e996e..709725e3b2 100644 --- a/test/src/runner/cli/testCliRunnerParallel.js +++ b/test/src/runner/cli/testCliRunnerParallel.js @@ -227,6 +227,7 @@ describe('Test CLI Runner in Parallel', function () { }, 'simulator.ios': { selenium: { + host: 'localhost', use_appium: true }, desiredCapabilities: {