Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] DefinitelyTyped npmcli__arborist does not match internal arborist.loadActual(options) #7628

Closed
2 tasks done
ghiscoding opened this issue Jul 4, 2024 · 1 comment
Closed
2 tasks done
Labels
Bug thing that needs fixing Needs Triage needs review for next steps

Comments

@ghiscoding
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

This issue exists in the latest npm version

  • I am using the latest npm

Current Behavior

The DefinitelyTyped npmcli__arborist is not matching the actual options from arborist.loadActual(options)

async #loadActual (options) {
// mostly realpath to throw if the root doesn't exist
const {
global,
filter = () => true,
root = null,
transplantFilter = () => true,
ignoreMissing = false,
forceActual = false,
} = options

it seems that none of the options matches what is available from DefinitelyTyped npmcli__arborist referenced below
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/3c78f0fd3c1bd7c16bde2b58e3dccadfccbdb0f1/types/npmcli__arborist/index.d.ts#L31-L79

Expected Behavior

DefinitelyTyped npmcli__arborist should match these options but it does not

async #loadActual (options) {
// mostly realpath to throw if the root doesn't exist
const {
global,
filter = () => true,
root = null,
transplantFilter = () => true,
ignoreMissing = false,
forceActual = false,
} = options

Steps To Reproduce

  1. all environments
  2. install @npmcli/arborist and @types/npmcli__arborist
  3. try to use existing option(s), for example { ignoreMissing: true }
  4. See error print screen below

image

Environment

  • npm: v10.1.0
  • Node.js: v20.9.0
  • OS Name: Windows 10
  • System Model Name:
  • npm config:
; copy and paste output from `npm config ls` here
@ghiscoding ghiscoding added Bug thing that needs fixing Needs Triage needs review for next steps labels Jul 4, 2024
@ghiscoding
Copy link
Author

oops I think this should be moved to npm/npm-packlist instead, so let me close it and reopen there npm/npm-packlist#238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Needs Triage needs review for next steps
Projects
None yet
Development

No branches or pull requests

1 participant