[BUG] semver.lt returns wrong value for pre-release version comparison

[IainSAP]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

Using semver.lt() returns the incorrect value when comparing pre-release version with includePrerelease set to false (or the default).

By comparison, explicitly coercing you get:

semver_1.lt(semver_1.coerce('0.2.0-1'), minVersion)
false

My assumption is that strings are implicitly coerced when calling comparison functions, perhaps this is incorrect?

Expected Behavior

semver.lt('0.2.0-1', '0.2.0', { includePrerelease: false }) should return false.

Steps To Reproduce

1. In node shell
2. With the current latest version of semver installed
3. Run 'require('semver').lt('0.2.0-1', '0.2.0', { includePrerelease: false })
4. Wrong value true is returned

Environment

• npm: 6.14.15
• Node: 14.8.1
• OS: Mac Monterey 12.5.1
• platform: Macbook Pro i9

[lukekarrys]

This is similar to #345, and I think the fix might even be the same for both.

[mbtools]

The comparison functions do not use the includePrerelease option! If major.minor.patch are the same, they always compare the pre-release parts.

Maybe the docs could be improved since it's suggesting that all functions use evaluate all options:

node-semver/README.md

Lines 402 to 414 in 868d4bb

	All methods and classes take a final `options` object argument. All
	options in this object are `false` by default. The options supported
	are:
	- `loose`: Be more forgiving about not-quite-valid semver strings.
	(Any resulting output will always be 100% strict compliant, of
	course.) For backwards compatibility reasons, if the `options`
	argument is a boolean value instead of an object, it is interpreted
	to be the `loose` param.
	- `includePrerelease`: Set to suppress the [default
	behavior](https://github.com/npm/node-semver#prerelease-tags) of
	excluding prerelease tagged versions from ranges unless they are
	explicitly opted into.

[6Demon6Child6]

Stop Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: Marc Bernard ***@***.***> Sent: Tuesday, January 21, 2025 3:22:14 PM To: npm/node-semver ***@***.***> Cc: Subscribed ***@***.***> Subject: Re: [npm/node-semver] [BUG] semver.lt returns wrong value for pre-release version comparison (Issue #483) The comparison<https://github.com/npm/node-semver/blob/868d4bbe3d318c52544f38d5f9977a1103e924c2/classes/semver.js#L91> functions do not use the includePrerelease option! If major.minor.patch are the same, they always compare the pre-release parts. Maybe the docs could be improved since it's suggesting that all functions use evaluate all options: https://github.com/npm/node-semver/blob/868d4bbe3d318c52544f38d5f9977a1103e924c2/README.md?plain=1#L402-L414 — Reply to this email directly, view it on GitHub<#483 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BD3O5J3DEAXS656T3LK6FGD2L23ANAVCNFSM6AAAAABVTOQFJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBVG43DINZVGI>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>