Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pointer interaction interferes with external event handlers #2052

Open
jheer opened this issue Apr 11, 2024 · 0 comments · May be fixed by #2267
Open

Pointer interaction interferes with external event handlers #2052

jheer opened this issue Apr 11, 2024 · 0 comments · May be fixed by #2267

Comments

@jheer
Copy link

jheer commented Apr 11, 2024

The pointerdown handler for the pointer interaction calls event.stopImmediatePropagation():
https://github.com/observablehq/plot/blob/main/src/interactions/pointer.js#L165

As a result, any event handlers added to the SVG after the fact are starved of expected pointerdown events. For example, in Mosaic vgplot this breaks discrete point selection if a Plot pointer or tip are active (uwdata/mosaic#361).

For greater interoperability, might it be possible to remove this line, and instead handle any necessary event suppression in a Plot-internal fashion? Thanks!
@jheer jheer mentioned this issue Apr 11, 2024
Open
Fil added a commit that referenced this issue Jan 3, 2025
@Fil
ignore the same event if it's already been processed
3099083 
(this typically happens on the crosshair mark which uses the same shared pointer transform on its submarks)

closes #2052
@Fil Fil linked a pull request Jan 3, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

let the pointer's pointerdown event propagate observablehq/plot
1 participant
@jheer