Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facility ID is undefined in Patient Details for Staff #10109

Open
rajku-dev opened this issue Jan 22, 2025 · 4 comments · May be fixed by #10121
Open

Facility ID is undefined in Patient Details for Staff #10109

rajku-dev opened this issue Jan 22, 2025 · 4 comments · May be fixed by #10121
Assignees
@Jacobjeevan
Labels
work-in-progress

Comments

@rajku-dev
Copy link
Contributor

rajku-dev commented Jan 22, 2025 •
edited
Loading

Describe the bug

  • Appointments tab shows loading even after requests have failed to fetch the data, it should be more user-friendly

Image

  • facilityId is undefined in the URL

Image

Steps to reproduce

  • Go to Dashboard > Staff > Patients > Click on any Patient > Appointments

Click here to reproduce
@rajku-dev
Copy link
Contributor Author

Hey team, I would like to work on this issue

@rajku-dev rajku-dev changed the title Issues in Patient Details for Staff Facility ID is undefined in Patient Details for Staff Jan 22, 2025
@rithviknishad
Copy link
Member

How are you planning to solve this?

@rajku-dev
Copy link
Contributor Author

rajku-dev commented Jan 23, 2025 •
edited
Loading

These patients in Staff section are not associated with any facility right?

Image

For editing the patient details we are using patientId in place of facilityId(which doesn't exist), i think this was done intentionally, is this for testing?

for UI we can show more user-friendly message instead of showing Loading.. like Couldn't fetch at this moment!

@github-actions github-actions bot added needs-triage question Further information is requested labels Jan 23, 2025
@Jacobjeevan
Copy link
Contributor

This is a bit more complicated than just that, some of the tab information is facility specific and shouldn't be displayed to users accessing from org level anyways 🤔

@Jacobjeevan Jacobjeevan self-assigned this Jan 23, 2025
@Jacobjeevan Jacobjeevan removed question Further information is requested needs-triage labels Jan 23, 2025
@Jacobjeevan Jacobjeevan linked a pull request Jan 23, 2025 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jacobjeevan Jacobjeevan

Labels
work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patient Detail Tabs: Org List Access Jacobjeevan/care_fe
3 participants
@rithviknishad @Jacobjeevan @rajku-dev