Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce "clear sample" in entity config to have an explicit null #19621

Open
TeddyCr opened this issue Jan 31, 2025 · 0 comments
Open

Introduce "clear sample" in entity config to have an explicit null #19621

TeddyCr opened this issue Jan 31, 2025 · 0 comments
Assignees
Labels

Comments

@TeddyCr
Copy link
Contributor

TeddyCr commented Jan 31, 2025

Describe the bug
On the table profiler config, if the sample config is moved, for example, from 36% to then 100% and we have a sample config set at the profiler level to 10%, then the table will not be sampled at 10% but 100% (since table sample takes precedence).

Expected behavior
If a user wants to clear the sample config set at the table level, the profilerSample attribute should be set to None. We need to introduce a clear button to allow users to explicitly clear the sample config

Image

Version:

  • OpenMetadata version: 1.6.x
@TeddyCr TeddyCr self-assigned this Jan 31, 2025
@TeddyCr TeddyCr removed this from Release 1.7.0 Jan 31, 2025
@TeddyCr TeddyCr added this to the Feb 25 - Sprint 1 milestone Jan 31, 2025
@TeddyCr TeddyCr moved this to Observability in Release 1.6.4 Feb 3, 2025
@TeddyCr TeddyCr assigned ShaileshParmar11 and unassigned TeddyCr Feb 3, 2025
@TeddyCr TeddyCr changed the title Introduce clear sample in entity config to have an explicit null Introduce "clear sample" in entity config to have an explicit null Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Observability
Development

No branches or pull requests

2 participants