You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
I am not sure whether it's a bug or wrongly defined logic, but I wanted to raise concern over mask_query method. In it's current form, mask_query is a method that:
will return masked query if masking succeeds
will return original query if masking does not succeed
Which I think is wrong (the second part). If a user relies on this method and masking was not possible, then it would return original query (possibly with sensitive data) without users knowledge. In automated scenarios this might cause leakage of sensitive information when masking fails but returned query is pushed for further processing (for example when enriching lineage edge). The method ideally either returns None or raises an exception if masking fails.
To Reproduce
Screenshots or steps to reproduce
Expected behavior mask_query does return None when masking fails.
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered:
mgorsk1
changed the title
mask query method should never be a passthrough one
mask query method should not return original query in case of exception
Feb 5, 2025
Affected module
Ingestion
Describe the bug
I am not sure whether it's a bug or wrongly defined logic, but I wanted to raise concern over mask_query method. In it's current form, mask_query is a method that:
Which I think is wrong (the second part). If a user relies on this method and masking was not possible, then it would return original query (possibly with sensitive data) without users knowledge. In automated scenarios this might cause leakage of sensitive information when masking fails but returned query is pushed for further processing (for example when enriching lineage edge). The method ideally either returns
None
or raises an exception if masking fails.To Reproduce
Screenshots or steps to reproduce
Expected behavior
mask_query does return
None
when masking fails.Version:
openmetadata-ingestion[docker]==XYZ
]Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: