Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charts: Update authz policy to be v1 compatible #273

Closed

Conversation

ashutosh-narkar
Copy link
Member

@ashutosh-narkar ashutosh-narkar commented Jan 21, 2025

Fixes: #272

Copy link
Contributor

@eshepelyuk eshepelyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I assume the OPA docker version also should be updated to v1 version
  2. Plz link this PR to the Helm chart not compatible with OPA v1 #272 with commit message, so it will be autoclosed. as described here

Fixes: open-policy-agent#272

Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
@ashutosh-narkar
Copy link
Member Author

  1. I assume the OPA docker version also should be updated to v1 version
  2. Plz link this PR to the Helm chart not compatible with OPA v1 #272 with commit message, so it will be autoclosed. as described here

Thanks for the review. Done. Please let me know if you have other suggestions. Thanks!

@ashutosh-narkar
Copy link
Member Author

There is a test failure. Maybe updating the values file caused it. Any idea @eshepelyuk?

@eshepelyuk
Copy link
Contributor

There is a test failure. Maybe updating the values file caused it. Any idea @eshepelyuk?

need some time to take a look at failing test(s)

@eshepelyuk
Copy link
Contributor

Hello @ashutosh-narkar
I am closing this PR in favour of #275, to be able to help you work on PR in the same branch.
Let's continue conversation there.

@eshepelyuk eshepelyuk closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart not compatible with OPA v1
2 participants