[cmd/otelcontribcol] remove manual replace for github.com/opencontainers/runc v1.1.14 #37486
Labels
Comments
songy23
pushed a commit
that referenced
this issue
Jan 24, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Support obfuscating SQL and Redis queries in APM stats in Datadog Connector. replace statement in otelcontribcol was necessary due to failing build in pipeline. It doesn't appear that any modules use any affected functions, but building otelcontribcol with ocb failed due to an API change. Also opened an issue to bump the `receiver/awscontainerinsight` dependency so that this replace can be removed in the future: #37486 <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Replaces #35401 <!--Describe what testing was performed and which tests were added.--> #### Testing Added TestObfuscate in connector_native_test.go <!--Describe the documentation added.--> #### Documentation added release note and link to semantics on Datadog vendor website <!--Please delete paragraphs that you did not use before submitting.-->
|
could also use a |
|
Pinging code owners for receiver/awscontainerinsight: @Aneurysm9 @pxaws. See Adding Labels via Comments if you do not have permissions to add labels yourself. For example, comment '/label priority:p2 -needs-triaged' to set the priority and remove the needs-triaged label. |
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this issue
Jan 26, 2025
…emetry#37457) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Support obfuscating SQL and Redis queries in APM stats in Datadog Connector. replace statement in otelcontribcol was necessary due to failing build in pipeline. It doesn't appear that any modules use any affected functions, but building otelcontribcol with ocb failed due to an API change. Also opened an issue to bump the `receiver/awscontainerinsight` dependency so that this replace can be removed in the future: open-telemetry#37486 <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Replaces open-telemetry#35401 <!--Describe what testing was performed and which tests were added.--> #### Testing Added TestObfuscate in connector_native_test.go <!--Describe the documentation added.--> #### Documentation added release note and link to semantics on Datadog vendor website <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
cmd/otelcontribcol
Describe the issue you're reporting
had to add a manual upgrade replacement for
opencontainers/runcpkg inotelcontribcoldue to datadogexporter dependency update: #37457receiver/awscontainerinsightreceiveris the only component using this package due to an implicit dependency from google/cadvisor package.That package has a PR to update their
runcdependency: google/cadvisor#3616Once that is merged, a PR to update
cadvisordependency inreceiver/awscontainerinsightreceivercan be bumped and this replace statement should be able to be removed.The text was updated successfully, but these errors were encountered: