Update TraceIdRatioBasedSampler.GetLowerLong to use lower 8 bytes #6055
Unanswered
AsakerMohd
asked this question in
Q&A
Replies: 1 comment 2 replies
-
|
I see in the PR comments that there was an outstanding TODO in the spec. Seems that hasn't been resolved yet. Would you be able to join the weekly .NET SIG meeting to discuss? |
Beta Was this translation helpful? Give feedback.
2 replies
-
|
When is it? I can try and join that. |
Beta Was this translation helpful? Give feedback.
-
|
https://github.com/open-telemetry/community?tab=readme-ov-file#calendar The .NET SIG meets every Tuesday. We alternate morning and afternoon meetings to accommodate as many timezones as possible. |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I wanted to get some traction back regarding this: #5707. I've opened this PR previously to update the traceIdRatioSampler to use the lower 8 bytes of the trace id instead of the first 8 since some traceId formats (like XRay) set the first 8 to the current timestamp and hence isn't really random. This is also to align with other languages like Python and Java. More details are found in the PR description.
Beta Was this translation helpful? Give feedback.
All reactions