Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] move PooledList to Zipkin #6092

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

SimonCropp
Copy link
Contributor

Fixes #
Design discussion issue #

Changes

PooledList is only used in Zipkin. so move it there and remove the Share Compile Include complexity

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@SimonCropp SimonCropp requested a review from a team as a code owner January 23, 2025 05:33
@github-actions github-actions bot added pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package labels Jan 23, 2025
@Kielek Kielek changed the title move PooledList to Zipkin [repo] move PooledList to Zipkin Jan 23, 2025
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not against this change, as it is used only by this project.

@CodeBlanch CodeBlanch merged commit 8fa00cb into open-telemetry:main Jan 24, 2025
49 checks passed
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.39%. Comparing base (2828321) to head (7217a7f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6092   +/-   ##
=======================================
  Coverage   86.39%   86.39%           
=======================================
  Files         257      257           
  Lines       11650    11650           
=======================================
  Hits        10065    10065           
  Misses       1585     1585           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants