Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress all gRPC Span Events; suppress all Span Events #6512

Open
fujin opened this issue Aug 26, 2022 · 7 comments
Open

Suppress all gRPC Span Events; suppress all Span Events #6512

fujin opened this issue Aug 26, 2022 · 7 comments
Labels
blocked on specification Needs specification work before this can be resolved enhancement New feature or request

Comments

@fujin
Copy link

fujin commented Aug 26, 2022

Is your feature request related to a problem? Please describe.
My distributed tracing vendor quota is consumed by span events attached to my spans (e.g. for both the span, and each event as an "event" - we have X events per month).

Describe the solution you'd like
I would like to suppress the span events in the gRPC instrumentation. I might also like to suppress all auto-instrumented span events globally or enable them on a case-by-case basis.

Describe alternatives you've considered

@fujin fujin added the enhancement New feature or request label Aug 26, 2022
@trask
Copy link
Member

trask commented Aug 15, 2023

@trask trask added the needs author feedback Waiting for additional feedback from the author label Aug 15, 2023
@fujin
Copy link
Author

fujin commented Aug 15, 2023

Yeah, we certainly could build one and package our own image+extension for usage with opentelemetry operator instrumentation injection. However, I would still prefer to disable by default / disable all span events without any additional work.

I ended up using a filter:

      filter/ottl:
        traces:
          spanevent:
            - 'name == "message"'
            - 'name == "ss"'
            - 'name == "cr"'

@github-actions github-actions bot removed the needs author feedback Waiting for additional feedback from the author label Aug 15, 2023
@trask
Copy link
Member

trask commented Aug 15, 2023

I would still prefer to disable by default / disable all span events without any additional work

is this not possible using the opentelemetry collector spanevent filter?

@fujin
Copy link
Author

fujin commented Aug 15, 2023

Yes of course, that's the filter that I mentioned in my previous reply; well, I am currently specifying each one to drop (by name). I would still prefer to not emit them by default/globally rather than discover a new one and filter it (potentially after eating event budget at my tracing vendor).

@trask
Copy link
Member

trask commented Aug 15, 2023

I think it would be worth making this request in the collector-contrib repo where that spanevent filter is maintained

@fujin
Copy link
Author

fujin commented Aug 15, 2023

hmm.. I'm not sure that I agree. Two different problems/solutions, no?

The code in this repository is responsible for emitting the span events that I would like my collector not to receive.

The collector configuration that filters those events is acceptable to us but doesn't allowing control over if they're emitted in the first place (without disabling that instrumentation library wholesale). I'd like to keep the instrumentation library, but not the events, without having to rely on a filter. I'm fine with closing it, but I would not say those are the same.

@trask
Copy link
Member

trask commented Dec 23, 2024

This is being worked on at the specification level now through a combination of

(and some followups will be needed still)

@trask trask added the blocked on specification Needs specification work before this can be resolved label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked on specification Needs specification work before this can be resolved enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants