Unsupported usage of MetricsLevel

[mx-psi]

👋 I am looking to drop MetricsLevel from component.TelemetrySettings, and replace this with a system with which components can pass to the service a set of views that control this (see open-telemetry/opentelemetry-collector/issues/11754).

otel-arrow is one of the two components that currently use MetricsLevel so I am analyzing how it uses MetricsLevel. There is one usage here:

otel-arrow/pkg/otel/arrow_record/consumer.go

Lines 199 to 201 in c39257c

	if c.metricsLevel > configtelemetry.LevelDetailed {
	kvs = append(kvs, c.uniqueAttr)
	}

that (AFAICT) would not be supported through views: views allow you to filter at the instrument level, but not at the timeseries level.

This would have to be removed or changed for addressing open-telemetry/opentelemetry-collector/issues/11061. To address this issue, I will create views to replicate the current behavior (see open-telemetry/opentelemetry-collector/pull/12143) and set the metrics level to a fixed value on the otelarrow receiver.

[jade-guiton-dd]

As far as I know, LevelDetailed is the highest possible metricsLevel; doesn't this mean that the conditional is never triggered?

[mx-psi]

Good catch, this seems like dead code then

[mx-psi]

I am going to unassign myself since there is nothing to do here for Collector 1.0

[jmacd]

Let's remove the code associated with this MetricsLevel.

[drewrelmas]

I will try and pick this one up and remove the unused code!

[drewrelmas]

@mx-psi have removed this code snippet. It is a step towards eventual removal of all MetricsLevel usage, but will require a few release cycles to fully remove as mentioned in #283.

[mx-psi]

Thank you! :)