Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't create 0.22.0 atari environment and new release has not updated version number #2624

Closed
pseudo-rnd-thoughts opened this issue Feb 17, 2022 · 3 comments

Comments

@pseudo-rnd-thoughts
Copy link
Contributor

pseudo-rnd-thoughts commented Feb 17, 2022

Bug 1.
Gym version number is 0.21.0 while the most recent release is 0.22.0
https://github.com/openai/gym/blob/master/gym/version.py
https://github.com/openai/gym/releases/tag/0.22.0

Bug 2.
I have cloned the repository and tried to create an atari environment however it throws an error about the seed

> import gym
> gym.make('ALE/Breakout-v5')
A.L.E: Arcade Learning Environment (version 0.7.4+069f8bd)
[Powered by Stella]
Traceback (most recent call last):
  File "/home/mark/anaconda3/envs/penguin/lib/python3.9/site-packages/IPython/core/interactiveshell.py", line 3251, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)
  File "<ipython-input-3-52e43c1205a5>", line 1, in <module>
    gym.make('Breakout')
  File "/home/mark/anaconda3/envs/penguin/lib/python3.9/site-packages/gym/envs/registration.py", line 676, in make
    return registry.make(id, **kwargs)
  File "/home/mark/anaconda3/envs/penguin/lib/python3.9/site-packages/gym/envs/registration.py", line 520, in make
    return spec.make(**kwargs)
  File "/home/mark/anaconda3/envs/penguin/lib/python3.9/site-packages/gym/envs/registration.py", line 140, in make
    env = cls(**_kwargs)
  File "/home/mark/anaconda3/envs/penguin/lib/python3.9/site-packages/gym/envs/atari/environment.py", line 123, in __init__
    self.seed()
  File "/home/mark/anaconda3/envs/penguin/lib/python3.9/site-packages/gym/envs/atari/environment.py", line 165, in seed
    self.np_random, seed1 = seeding.np_random(seed)
AttributeError: can't set attribute

This git commit appears to be the cause of the problem - 2be9e60
The problem doesn't occur with the previous commit - 8819d56

But I can't work out what the issue is as the commit doesn't change any of the code in envs/atari/environment.py

@jkterry1
Copy link
Collaborator

Hey, thanks a ton, I'm really glad you caught these before we pushed to PyPI. I just fixed the version on master, #2625 will fix the bigger issue.

Additionally- would be be interested in working on contributions to Gym going forward?

@pseudo-rnd-thoughts
Copy link
Contributor Author

@jkterry1 Thanks, it was mostly luck that I found the issues

For contributing towards Gym in the future, I would be happy to help.
I noticed the roadmap for 1.0 (#2524)
Is there anything else to work on? And to discuss what different people are working on?

@jkterry1
Copy link
Collaborator

@pseudo-rnd-thoughts could you please email me to discuss at jkterry@umd.edu?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants