Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release on nuget isn't signed #307

Open
jaimecbernardo opened this issue Dec 11, 2024 · 2 comments
Open

Release on nuget isn't signed #307

jaimecbernardo opened this issue Dec 11, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@jaimecbernardo
Copy link

Service

OpenAI

Describe the bug

The binary files from the release that's on nuget aren't digitally signed.
Some environments require that everything that runs is signed, so we need to sign these files ourselves when we consume this package.
It would be better if it's signed by OpenAI, for example, so that the source can be trusted.
image

Steps to reproduce

  1. Download the nuget package.
  2. Extract it (easily done by renaming the extension as a zip file).
  3. Navigate to "lib\net6.0" or "lib\netstandard2.0" .
  4. Right-click OpeanAI.dll and choose "Properties".
  5. Verify in the Digital Signatures that the binary file is unsigned.

Code snippets

No response

OS

winOS

.NET version

9.0.0

Library version

2.0.0, 2.1.0 and most likely all others as well.

@jaimecbernardo jaimecbernardo added the bug Something isn't working label Dec 11, 2024
@jaimecbernardo
Copy link
Author

Thank you 😉

@AngelosP
Copy link
Contributor

AngelosP commented Dec 16, 2024

I can confirm that the binary OpenAI.dll is not signed

image

Here is System.ClientModel.dll as a comparison

image

@joseharriaga and @ShivangiReja I'm going to start internal comms to figure out the right key to use for the signing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants