Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imprecise changelog items related to nonce endpoint #445

Open
matzf opened this issue Jan 13, 2025 · 2 comments · May be fixed by #450
Open

Imprecise changelog items related to nonce endpoint #445

matzf opened this issue Jan 13, 2025 · 2 comments · May be fixed by #450
Assignees
Labels
Milestone

Comments

@matzf
Copy link

matzf commented Jan 13, 2025

The document history contains small errors related to adding the nonce endpoint and removing c_nonce from token and credential endpoints:

The following entries in the -14 subsection of the document history refer to changes that were completed in draft version 15:

* removed c_nonce and c_nonce_expires_in from the token endpoint response
* added a Nonce Endpoint where a Client can acquire a fresh c_nonce value without the overhead of a full Credential Request

The following entry in the -15 subsection of the document history is inaccurate:

* removes `c_nonce` and `c_nonce_expires_in` from the Credential Error Response

The c_nonce fields were removed from the credential endpoint entirely, both for success and error responses.

@babisRoutis
Copy link
Contributor

Indeed I have also noticed those small discrepancies.

For draft 14, I think the correct version is here

@Sakurann Sakurann linked a pull request Jan 22, 2025 that will close this issue
@Sakurann Sakurann self-assigned this Jan 22, 2025
@Sakurann
Copy link
Collaborator

please review the PR

@Sakurann Sakurann added this to the Final 1.0 milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants