-
Notifications
You must be signed in to change notification settings - Fork 364
Comparing changes
Open a pull request
base repository: openrewrite/rewrite
base: v8.42.5
head repository: openrewrite/rewrite
compare: main
Commits on Jan 3, 2025
-
Fix parsing string literal with line breaks and spaces (#4843)
* Fix parsing of string literals with linebreaks and spaces * Use `getDelimiter` for GStringExpression * Improve stringLiteralInParentheses test * Remove temporary moreParenthesesStuff test * Revert escapeCharacters test * Remove `lengthAccordingToAst`, use same trick for ConstantExpression in GString * Fix typo
Configuration menu - View commit details
-
Copy full SHA for 8a9a449 - Browse repository at this point
Copy the full SHA 8a9a449View commit details -
Add TOML language parser (#4845)
* Add TOML language parser * Polish and address bot review comments * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update rewrite-toml/src/main/java/org/openrewrite/toml/internal/grammar/TomlParserVisitor.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Tim te Beek <tim@moderne.io> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 02411bd - Browse repository at this point
Copy the full SHA 02411bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 19dfd6a - Browse repository at this point
Copy the full SHA 19dfd6aView commit details -
2
Configuration menu - View commit details
-
Copy full SHA for 6dd029f - Browse repository at this point
Copy the full SHA 6dd029fView commit details -
Adding option cutOffDate to RemoveOwaspSuppressions (#4846)
* Adding option cutOffDate to RemoveOwaspSuppressions There are cases were we want to only remove suppressions up to a specific date, this allows a cut off date to be provided when removed expired suppressions * Update rewrite-xml/src/main/java/org/openrewrite/xml/security/RemoveOwaspSuppressions.java Co-authored-by: Tim te Beek <tim@moderne.io> --------- Co-authored-by: Tim te Beek <tim@moderne.io>
Configuration menu - View commit details
-
Copy full SHA for e6a8499 - Browse repository at this point
Copy the full SHA e6a8499View commit details
Commits on Jan 6, 2025
-
Configuration menu - View commit details
-
Copy full SHA for c455436 - Browse repository at this point
Copy the full SHA c455436View commit details -
Skip parsing groovy generated transform methods (#4848)
* Skip parsing groovy generated transform methods * Skip parsing groovy generated transform methods * Skip parsing groovy generated transform methods * Skip parsing groovy generated transform methods * improvement * improvement * improvement * improvement
Configuration menu - View commit details
-
Copy full SHA for a3249f2 - Browse repository at this point
Copy the full SHA a3249f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1d0f36 - Browse repository at this point
Copy the full SHA a1d0f36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28d88c4 - Browse repository at this point
Copy the full SHA 28d88c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 621dcfa - Browse repository at this point
Copy the full SHA 621dcfaView commit details
Commits on Jan 7, 2025
-
Add recipe to enable Develocity build cache in xml configuration (#4856)
* Add enable buildcache recipe * Polish * Use `<local><enabled>` * Rename recipe to be Develocity specific, to avoid confusion with Maven build cache --------- Co-authored-by: Tim te Beek <tim@moderne.io>
Configuration menu - View commit details
-
Copy full SHA for 15f7751 - Browse repository at this point
Copy the full SHA 15f7751View commit details -
HCL - comments in multilines
for
(#4858)* UT for #4857 * Fixing lexer to accept comemnts within for expressions * licenseFormat
Configuration menu - View commit details
-
Copy full SHA for fd71955 - Browse repository at this point
Copy the full SHA fd71955View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3f17ce - Browse repository at this point
Copy the full SHA b3f17ceView commit details -
Lombok support for java 21 (#4860)
* Lombok support for java 21 * Minimize diff with Java 17 to make it easier to spot intentional changes * Minimize diff some more to add missing `var` handling --------- Co-authored-by: Tim te Beek <tim@moderne.io>
Configuration menu - View commit details
-
Copy full SHA for 6ddcc37 - Browse repository at this point
Copy the full SHA 6ddcc37View commit details -
HCL - comments as the final lines (#4861)
* Support final line being a comment * licenseFormat
Configuration menu - View commit details
-
Copy full SHA for 0e5b439 - Browse repository at this point
Copy the full SHA 0e5b439View commit details
Commits on Jan 8, 2025
-
Configuration menu - View commit details
-
Copy full SHA for c2e5624 - Browse repository at this point
Copy the full SHA c2e5624View commit details -
Configuration menu - View commit details
-
Copy full SHA for 789ac5f - Browse repository at this point
Copy the full SHA 789ac5fView commit details -
Mark
PlainText
all-args constructor as privateAdd back the previous constructor without the `SoftReference<References>` as public.
Configuration menu - View commit details
-
Copy full SHA for 6bfac94 - Browse repository at this point
Copy the full SHA 6bfac94View commit details -
Check for
null
inTabsAndIndentsVisitor#visitContainer()
In case the caller doesn't have a guard on this.
Configuration menu - View commit details
-
Copy full SHA for 3b3a56c - Browse repository at this point
Copy the full SHA 3b3a56cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 13b6168 - Browse repository at this point
Copy the full SHA 13b6168View commit details
Commits on Jan 9, 2025
-
fix: create dependencyResourceLoaders in 2 passes (#4870)
* fix: create dependencyResourceLoaders in 2 passes * Inline variables used once --------- Co-authored-by: Tim te Beek <tim@moderne.io>
Configuration menu - View commit details
-
Copy full SHA for 1bb9da0 - Browse repository at this point
Copy the full SHA 1bb9da0View commit details -
HCL - Fixing empty comment handling (#4871)
* Fixing empty comment handling * Newline Co-authored-by: Tim te Beek <tim@moderne.io> --------- Co-authored-by: Tim te Beek <tim@moderne.io>
Configuration menu - View commit details
-
Copy full SHA for 7566b00 - Browse repository at this point
Copy the full SHA 7566b00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0826417 - Browse repository at this point
Copy the full SHA 0826417View commit details -
Configuration menu - View commit details
-
Copy full SHA for d11eae9 - Browse repository at this point
Copy the full SHA d11eae9View commit details -
Map trailing commas as
TrailingComma
Marker
, to fixJ.Erroneous
…… issues seen (#4869) * Do not allow J.Erroneous LST nodes by default in tests * Allow erroneous nodes in FindCompileErrorsTest * Use `TrailingComma` marker for enum values and array initializers Add an overload for `ReloadableJava17ParserVisitor#convert()` which allows supplying a `Markers` function, so that we can capture trailing commas using a `TrailingComma` marker and then also avoid the issue with the `J.Erroneous` getting constructed. * Update whitespace handling for last enum constant The last enum constant should only be right-padded if it has a trailing comma or semicolon. This is important because the whitespace after it belongs to the prefix of the next statement or the `J.Block#end`. * Allow errorneous nodes in specific tests * Update JavaDoc for typeValidation.erroneous after feedback * Use overloaded method * Apply to Java 21 parser as well * Format Java 21 parser * Apply to Java 11 parser as well * Apply to Java 8 parser as well * Fix failing tests * Minimize diff between versions to make it easier to compare --------- Co-authored-by: Knut Wannheden <knut@moderne.io> Co-authored-by: Laurens Westerlaken <laurens.westerlaken@jdriven.com>
Configuration menu - View commit details
-
Copy full SHA for 82b61de - Browse repository at this point
Copy the full SHA 82b61deView commit details -
Don't cache filePatterns at Recipe class level... caused strange beha…
…vior on the saas. At least I think that's why I was matching too many things with FindSourceFiles on the saas but couldn't reproduce locally.
Configuration menu - View commit details
-
Copy full SHA for 4c901ff - Browse repository at this point
Copy the full SHA 4c901ffView commit details
Commits on Jan 10, 2025
-
Configuration menu - View commit details
-
Copy full SHA for e69e8ca - Browse repository at this point
Copy the full SHA e69e8caView commit details -
Fix #4877 where the groovy parser would fail to parse variables whose…
… names started with "def"
Configuration menu - View commit details
-
Copy full SHA for fa1fc56 - Browse repository at this point
Copy the full SHA fa1fc56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fc0dba - Browse repository at this point
Copy the full SHA 9fc0dbaView commit details -
Partial support Lombok for java 8 (mostly done) (#4855)
* Support Lombok for java 8 * Support Lombok for java 8 * Support Lombok for java 8 * Add rewrite-java-lombok to classpath * Improve message * Remove `TimedTodo` to be more like the other java parsers * cleanup * Add JavaCompiler `delegate` fix * Support Lomboks `var` and `val` for Java 8 * Cleanup * Cleanup * Cleanup of `isLombokGenerated` methods * Cleanup of `isLombokGenerated` methods * Cleanup of `isLombokGenerated` methods * Cleanup of `isLombokGenerated` methods * Cleanup of `isLombokGenerated` methods * Cleanup * Improve `onConstructor` and `onConstructorNoArgs` args * Fix missing `onConstructor_` check * Cleanup * Apply suggestions from code review Co-authored-by: Knut Wannheden <knut@moderne.io> * Improve tests * Merge branch 'main' into lombok-java-8 * Rename JavacAnnotationHandler with no action to XNoOpHandler * Rename JavacAnnotationHandler with no action to XNoOpHandler * Improve lomboks `ExampleException` test --------- Co-authored-by: Knut Wannheden <knut@moderne.io>
Configuration menu - View commit details
-
Copy full SHA for 50d160e - Browse repository at this point
Copy the full SHA 50d160eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6609c8c - Browse repository at this point
Copy the full SHA 6609c8cView commit details -
Add recipe to enable Develocity build cache for Gradle (#4859)
* Add enable buildcache recipe for gradle * Fix description * Update test cases and rename config * Add initial version of visitor * Update rewrite-gradle/src/main/java/org/openrewrite/gradle/EnableDevelocityBuildCache.java Co-authored-by: Jacob van Lingen <jacob.van.lingen@moderne.io> * Indent fix * Polish * Change validation * Remove linebreaks * Simplify how build cache is created and extracted * Only look for develocity at the root, and buildCache within that * Show a richer example for `remotePushEnabled` --------- Co-authored-by: Jacob van Lingen <jacob.van.lingen@moderne.io> Co-authored-by: Tim te Beek <tim@moderne.io>
Configuration menu - View commit details
-
Copy full SHA for 6ff7a03 - Browse repository at this point
Copy the full SHA 6ff7a03View commit details -
For updating various readmes in the future
Configuration menu - View commit details
-
Copy full SHA for cd013f4 - Browse repository at this point
Copy the full SHA cd013f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 882291b - Browse repository at this point
Copy the full SHA 882291bView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb5a059 - Browse repository at this point
Copy the full SHA cb5a059View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd67fe6 - Browse repository at this point
Copy the full SHA dd67fe6View commit details
Commits on Jan 12, 2025
-
Enable
AnnotationMatcher
to match values inJ.NewArray
(#4889)* improve `AnnotationMatcher` to match on values in `J.NewArray` initializers values * update java doc
Configuration menu - View commit details
-
Copy full SHA for 4a8a38b - Browse repository at this point
Copy the full SHA 4a8a38bView commit details
Commits on Jan 13, 2025
-
Print cursor when tests fail to run a recipe (#4891)
* Print cursor when tests fail to run a recipe * Fail with the original exception, not a new one
Configuration menu - View commit details
-
Copy full SHA for 6a818cf - Browse repository at this point
Copy the full SHA 6a818cfView commit details -
Add TomlVisitorTest after seeing ClassCastException in arrays (#4892)
* Add TomlVisitorTest after seeing ClassCastException in arrays * Have Toml.Literal implement TomlValue * Drop unnecessary cast instead
Configuration menu - View commit details
-
Copy full SHA for 6f3416f - Browse repository at this point
Copy the full SHA 6f3416fView commit details -
Lombok's generated @with method misses type information; fix for Java…
Configuration menu - View commit details
-
Copy full SHA for aeb5bf2 - Browse repository at this point
Copy the full SHA aeb5bf2View commit details -
Add
slf4j-nop
transitively through rewrite-test (#4895)* Add `slf4j-nop` transitively through rewrite-test To reduce warnings seen about https://www.slf4j.org/codes.html#StaticLoggerBinder * Prevent new warning about two implementations
Configuration menu - View commit details
-
Copy full SHA for 30c9156 - Browse repository at this point
Copy the full SHA 30c9156View commit details -
LatestRelease
should replacemetadataPattern
as regex, as documen……ted (#4894) * Fix version comparator * LatestRelease.metadataPattern should be matched as a regex --------- Co-authored-by: Tim te Beek <tim@moderne.io>
Configuration menu - View commit details
-
Copy full SHA for cce9f3e - Browse repository at this point
Copy the full SHA cce9f3eView commit details
Commits on Jan 15, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 8a060c6 - Browse repository at this point
Copy the full SHA 8a060c6View commit details -
HCL - support for legacy syntax for attribute expressions (#4901)
* Support for LegacyIndexAttributeExpression * licenseFormat * Space.Location.LEGACY_INDEX_ATTRIBUTE_ACCESS * LegacyIndexAttributeAccess.index is int * Padding for LegacyAttributeAccess.base
Configuration menu - View commit details
-
Copy full SHA for db9f188 - Browse repository at this point
Copy the full SHA db9f188View commit details -
Add new parameter
oldAttributeValue
to `AddOrUpdateAnnotationAttrib……ute` recipe (#4881) * Add new parameter `oldAttributeValue` to `AddOrUpdateAnnotationAttribute` * enhance add test for Enum and class values * implement checks for `oldAttributeValue` * small fixes and a reproducer for adding array values to implicite values * fix handling of implicit and explicit value handling * fix handling of implicit and explicit value handling in arrays * Skip supporting source files, and extract constant * add contract to handle nullability * remove comments from debugging --------- Co-authored-by: Tim te Beek <tim@moderne.io>
Configuration menu - View commit details
-
Copy full SHA for 09dfe06 - Browse repository at this point
Copy the full SHA 09dfe06View commit details -
* TOML model cleanups Added a few missing `@Nullable` annotations and added accessors for `Toml.Table#name`. * Add two more overrides to `TomlIsoVisitor`
Configuration menu - View commit details
-
Copy full SHA for c80874b - Browse repository at this point
Copy the full SHA c80874bView commit details
Commits on Jan 16, 2025
-
When resolving maven pom properties give system properties precedence.
This matches Maven's own behavior.
Configuration menu - View commit details
-
Copy full SHA for 2586748 - Browse repository at this point
Copy the full SHA 2586748View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cd1e2a - Browse repository at this point
Copy the full SHA 6cd1e2aView commit details -
Correct TOML table parsing (#4910)
* Correct TOML table parsing Tables in TOML are not nested. I.e. the following should result in an AST with two top-level tables: ```toml [table-1] key1 = "some string" key2 = 123 [table-2] key1 = "another string" key2 = 456 ``` This has now been corrected in the parser. * Adjust Gradle build script for ANTLR generation * Add missing line terminators
Configuration menu - View commit details
-
Copy full SHA for 462dc74 - Browse repository at this point
Copy the full SHA 462dc74View commit details -
Add a test validation that execution context is not mutated during re…
…cipe execution (#4879) * Add a test validation that execution context is not mutated during the recipe run. * Allow messages from MavenExecutionContextView
Configuration menu - View commit details
-
Copy full SHA for 36efb73 - Browse repository at this point
Copy the full SHA 36efb73View commit details
There are no files selected for viewing