-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR Commenting bot doesn't work with forked repo's creating a PR #37
Comments
To add a bit more information: |
Seeing as your PR changes to search API and this commit seems to change away from search API 99348f4 |
Forgot to post the actual old version of the script that I mention. Here it is. https://github.com/oprypin/nightly.link/blob/4e83d1452dd1bf350ebe1a3910e395e6cf447fdf/.github/workflows/pr-comment.yml |
I tried the old version in my repo https://github.com/ooshlablu/performous |
I certainly am having this problem. Can it have anything to do with the recent update of actions/github-script to v6? |
You tell me ¯\_(ツ)_/¯ |
Here's the version you suggest, working fine with a PR: |
OK so in the meantime you can simply use that if it works better. There's no requirement that the script currently merged in the main branch here needs to be used, there are no permanent references to it. |
In the test repo I did try out the new/current version just to verify; it fails as described here. But the old version, https://github.com/oprypin/nightly.link/blob/4e83d1452dd1bf350ebe1a3910e395e6cf447fdf/.github/workflows/pr-comment.yml works OK. |
For me, just reverting to https://github.com/oprypin/nightly.link/blob/4e83d1452dd1bf350ebe1a3910e395e6cf447fdf/.github/workflows/pr-comment.yml did not work, I got:
did anyone find a stable solution that works with the current API? |
This might be a working option: https://github.com/HarbourMasters/Shipwright/blob/071a2d0418d6fb7464a1ddccd2b647683da38eff/.github/workflows/pr-artifacts.yml |
Within Performous we're trying to use the PR Commenting. All works fine when the main repo creates a branch and opens a PR. (can be seen here: performous/performous#725)
However upon opening a PR from a forked repo branch into the main master (can be seen here: performous/performous#726 getting the error:
These are the workflows within our master branch: https://github.com/performous/performous/tree/master/.github/workflows
The text was updated successfully, but these errors were encountered: