Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider replacing Clog with Timber #304

Closed
cjbrooks12 opened this issue Aug 23, 2019 · 1 comment
Closed

Consider replacing Clog with Timber #304

cjbrooks12 opened this issue Aug 23, 2019 · 1 comment
Labels
chore good first issue refactor Task Type: Refactoring, code cleanup, etc.

Comments

@cjbrooks12
Copy link
Contributor

cjbrooks12 commented Aug 23, 2019 •
edited
Loading

JakeWharton/timber offers nearly the same API as Clog (both were essentially ports of android.util.Log), and is currently/nearly a Kotlin/Multiplatform project, which means it could be used in normal JVM projects. By switching to that library, Orchid will be more adapted to a more industry-standard logger implementation, and then I will not need to maintain Clog any longer.

When using Timber, a Tree should be planted with, essentially, the custom loggers set up for Clog. For an initial implementation, it would probably be easiest to just pass the args directly from Timber through to Clog (so both libraries are in use for incremental migration, but the intended API usage is Timber).
@cjbrooks12 cjbrooks12 added refactor Task Type: Refactoring, code cleanup, etc. good first issue chore labels Aug 23, 2019
@cjbrooks12
Copy link
Contributor Author

Moved to #336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore good first issue refactor Task Type: Refactoring, code cleanup, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cjbrooks12