Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement version check mechanism between daemon and stack #33

Open
umgefahren opened this issue Dec 3, 2024 · 4 comments
Open

Implement version check mechanism between daemon and stack #33

umgefahren opened this issue Dec 3, 2024 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@umgefahren
Copy link
Contributor

We should implement a version check mechanism between the daemon and the stack. It's not good that there isn't one

@umgefahren umgefahren added the bug Something isn't working label Dec 3, 2024
@umgefahren umgefahren added this to the Launch milestone Dec 3, 2024
@Zollerboy1
Copy link
Contributor

Should this check for exact version matches or can we be less strict? I guess, in the same vein, we should also introduce version checks for all communication over grpc (i.e. between stack and script, as well as soon between stack and cli)?

@umgefahren
Copy link
Contributor Author

Should this check for exact version matches or can we be less strict?

Let's just use SemVer and issue a warning if we are a aware of another version that exists and we could update too.

I guess, in the same vein, we should also introduce version checks for all communication over grpc (i.e. between stack and script, as well as soon between stack and cli)?

Yes and the SDKs too (maybe).

@Lxixnxuxs just pinging you here because you are working on the CLI.

@Zollerboy1
Copy link
Contributor

Let's just use SemVer and issue a warning if we are a aware of another version that exists and we could update too.

I don't understand this. Can you elaborate?

@umgefahren
Copy link
Contributor Author

The components have a semver conformant version. A dependency (i.e. hyvectl depends on hyved) specifies a minimum required version (as standard to semver) and will throw an error or warning on a version mismatch. We can also hardcode the newest version of the dependency we are aware of (at build time) so we can drop hints that a restart or update might be available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants