New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encrypt repository locations with Travis and pass through to deployment scripts #43

Open

antonfelich opened this issue Jul 18, 2017 · 1 comment

antonfelich commented Jul 18, 2017

Repository locations are stored unencrypted in the source code, these contain our account number and should not be public.

Collaborator

humblelistener commented Jul 19, 2017

By repository locations, I reckon @antonfelich refers to the ECR urls. The account number mentioned in that is the concern, I believe.

While encrypting the account number is a good option, I wonder if there is a way to avoid mentioning an account number to push the docker image?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment