We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
we currently have an unfortunate restriction for the --dev mode (LocalPayloadBuilder):
because of this bound
reth/crates/node/builder/src/launch/engine.rs
Lines 79 to 82 in 2652ec8
we require that this struct
reth/crates/engine/local/src/payload.rs
Line 13 in 2652ec8
is: PayloadAttributesBuilder
PayloadAttributesBuilder
which made this workaround necessary
Lines 63 to 67 in 2652ec8
we can fix this problem by
trait MaybeDevLauncherAddOn
reth/crates/node/builder/src/rpc.rs
Lines 582 to 593 in 2652ec8
this way we can make the dev mode launcher smarter.
cc @Bisht13
ref #14062
No response
The text was updated successfully, but these errors were encountered:
Cool, can you assign this to me?
Sorry, something went wrong.
Bisht13
Successfully merging a pull request may close this issue.
Describe the feature
we currently have an unfortunate restriction for the --dev mode (LocalPayloadBuilder):
because of this bound
reth/crates/node/builder/src/launch/engine.rs
Lines 79 to 82 in 2652ec8
we require that this struct
reth/crates/engine/local/src/payload.rs
Line 13 in 2652ec8
is:
PayloadAttributesBuilder
which made this workaround necessary
reth/crates/engine/local/src/payload.rs
Lines 63 to 67 in 2652ec8
we can fix this problem by
PayloadAttributesBuilder
trait MaybeDevLauncherAddOn
, similar to:reth/crates/node/builder/src/rpc.rs
Lines 582 to 593 in 2652ec8
this way we can make the dev mode launcher smarter.
cc @Bisht13
ref #14062
Additional context
No response
The text was updated successfully, but these errors were encountered: