From 874872aced8f63a0b2bc41e438ad89563aac1515 Mon Sep 17 00:00:00 2001
From: Paul DobbinSchmaltz <p.dobbinschmaltz@icloud.com>
Date: Mon, 27 Jan 2025 14:59:05 -0600
Subject: [PATCH] Turn off Turbo prefetch for most links

Instead of zeroing in on each link or link type to not pre-fetch, this
commit just disabled it for entire pages.

See: https://turbo.hotwired.dev/handbook/drive#prefetching-links-on-hover

I'm making this change, not because I've seen and measured that we're
seeing too much activity on the site. But, just out of a gut feel that
it's not worth the extra requests when hovering over links. We've
already got so many requests coming in just for the Game play itself!
So I'm just proactively making this change. Besides, the pages load so
fast on their own that the pre-fetch doesn't seem to add much of
anything.
---
 app/views/application/_footer.html.erb | 1 +
 app/views/games/_listings.html.erb     | 1 -
 app/views/games/index.html.erb         | 8 +++++---
 app/views/metrics/show.html.erb        | 5 ++++-
 app/views/users/show.html.erb          | 5 ++++-
 5 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/app/views/application/_footer.html.erb b/app/views/application/_footer.html.erb
index 29c65631..3ab1e61f 100644
--- a/app/views/application/_footer.html.erb
+++ b/app/views/application/_footer.html.erb
@@ -6,6 +6,7 @@
     flex max-lg:flex-col gap-y-6
     justify-between items-center
   "
+  data-turbo-prefetch="false"
 >
   <nav class="lg:order-2 max-lg:w-full">
     <ul class="flex justify-between items-center gap-x-24 lg:gap-x-8">
diff --git a/app/views/games/_listings.html.erb b/app/views/games/_listings.html.erb
index b94b88e8..3b9d9654 100644
--- a/app/views/games/_listings.html.erb
+++ b/app/views/games/_listings.html.erb
@@ -12,7 +12,6 @@
                 engagement_tally: listings_date) %>
         </h4>
         <div
-          data-turbo-prefetch="false"
           class="
             grid sm:grid-cols-2 lg:grid-cols-3 xl:grid-cols-4 2xl:grid-cols-5 3xl:grid-cols-6
             gap-y-1
diff --git a/app/views/games/index.html.erb b/app/views/games/index.html.erb
index be728c97..a97de8ad 100644
--- a/app/views/games/index.html.erb
+++ b/app/views/games/index.html.erb
@@ -3,7 +3,10 @@
 
 <%= turbo_stream_from(@view.turbo_stream_name) %>
 
-<div class="container mx-auto space-y-12">
+<div
+  class="container mx-auto space-y-12"
+  data-turbo-prefetch="false"
+>
   <div class="flex max-lg:flex-col justify-between gap-y-6">
     <h1><%= title %></h1>
 
@@ -24,8 +27,7 @@
           <%= link_to(
                 type.filter_name,
                 type.games_filter_url,
-                class: type.css,
-                data: { turbo_prefetch: "false" }) %>
+                class: type.css) %>
           <span class="text-dim-lg">
             (<%= type.games_count %> / <%= type.games_percentage %>)
           </span>
diff --git a/app/views/metrics/show.html.erb b/app/views/metrics/show.html.erb
index 0f9e375d..1e1dab1d 100644
--- a/app/views/metrics/show.html.erb
+++ b/app/views/metrics/show.html.erb
@@ -1,7 +1,10 @@
 <% title("Metrics") %>
 <% description(t("metrics.meta_description")) %>
 
-<div class="container mx-auto space-y-12">
+<div
+  class="container mx-auto space-y-12"
+  data-turbo-prefetch="false"
+>
   <h1><%= title %></h1>
 
   <% @view.engagements.tap do |engagements| %>
diff --git a/app/views/users/show.html.erb b/app/views/users/show.html.erb
index dd4c7536..807632b5 100644
--- a/app/views/users/show.html.erb
+++ b/app/views/users/show.html.erb
@@ -1,7 +1,10 @@
 <% title(@view.display_name) %>
 <% description(t("user.meta_description")) %>
 
-<div class="container mx-auto">
+<div
+  class="container mx-auto"
+  data-turbo-prefetch="false"
+>
   <div class="space-y-10">
     <div class="xl:w-2/3 space-y-6">
       <h1 class="border-b border-dotted border-dim">