-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using deprecated set-output
#15
Comments
Let's try to update the full upstream stack via #16 |
This is already reported upstream and tracked via actions/toolkit#1218 Temporary Suggestion: const os = require("os")
const fs = require("fs")
function setOutput(key, value) {
// Temporary hack until core actions library catches up with github new recommendations
const output = process.env['GITHUB_OUTPUT']
fs.appendFileSync(output, `${key}=${value}${os.EOL}`)
} Probably better to wait for a fix from upstream |
This should be fixed already upstream, right? |
this is not fixed upstream view https://github.com/actions/toolkit/blob/main/packages/core/src/core.ts#L199 export function setOutput(name: string, value: any): void {
const filePath = process.env['GITHUB_OUTPUT'] || ''
if (filePath) {
return issueFileCommand('OUTPUT', prepareKeyValueMessage(name, value))
}
process.stdout.write(os.EOL)
issueCommand('set-output', {name}, toCommandValue(value))
} |
there is a case to fix it we should track actions/toolkit#1336 |
This is getting urgent. Two weeks left (maybe?): From https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ |
probably consider using |
this should now be fixed by 798bfcd |
Need to adjust
set-output
usage, this is currently throwing that warningThe text was updated successfully, but these errors were encountered: