Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up “Play Pokémon” and “New Game” #30

Open
iimarckus opened this issue Jun 23, 2018 · 2 comments
Open

Set up “Play Pokémon” and “New Game” #30

iimarckus opened this issue Jun 23, 2018 · 2 comments

Comments

@iimarckus
Copy link
Member

iimarckus commented Jun 23, 2018

The menu entries need to exist and set proper flags. Anything else?

@iimarckus iimarckus added this to the Translation milestone Jun 23, 2018
@iimarckus
Copy link
Member Author

130bf9b gets partway there: it displays all the menu entries except Continue. The Continue check for an extant save file is wrong (it thinks a save exists when it doesn’t).

New Game still needs to be updated to set the right flags. In the original ROM the two behave identically.

@iimarckus
Copy link
Member Author

Play Pokémon and New Game now start the demo and the regular game, respectively (5020670).

New Game doesn’t have a save option in the start menu; this needs to be fixed.

Continue still needs to be fixed. Apparently $ce60 is the equivalent of pokecrystal’s wSaveFileExists. It should be zero when there’s no save data, but it’s nonzero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants