Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a Gradle Build system to the Processing IDE #888

Open
wants to merge 122 commits into
base: main
Choose a base branch
from

Conversation

Stefterv
Copy link
Collaborator

@Stefterv Stefterv commented Dec 14, 2024

Here's the first pull-request adding a new Gradle build system to the Processing IDE.

The GitHub Actions will create distributable binaries for macOS (x64, aarch64), windows (x64) and linux (x64, aarch64). The other platforms will need their own CI/CD system, but I think the repo will already build on the other platforms.

In terms of compatibility I've come pretty far but I'm sure there is some functionality that I have missed.

New Features

  • Installers for macOS (dmg), Widows (msi), linux (deb)
  • Windows: Start menu item
  • Jetpack Compose
  • Kotlin Support for the IDE
  • Splash screen Refactor + Animation
  • Additional pde:// schema functions (To be documented)

Functionality to test and verify

  • Examples
  • Tweaks mode
  • P2D
  • Debugger
  • Languages
  • Contributed libraries
  • Autocomplete
  • MovieMaker
  • Exporting Applications
  • processing-java
  • java mode default libraries (dxf,svg,io,net,serial,pdf)
  • Python mode (BROKEN, already on 4.3.1 macOS aarch64, other platforms okay)
  • Android mode

To add during this pull request

To improve during this pull request

  • Legacy resource handling (rn it copies all assets to temp folder on launch)
  • Move all dependencies to libs.versions.toml
  • Version and Build number

After pull request

To consider

  • Appstores

In any case, this pull request does not break the existing Ant build system so we can either wait with the merge or we can have the Gradle version available as a preview.

The bundle size has increased quite a bit since we are shipping a JRE and a JDK instead of using the JDK to run the IDE
|linux-x64 | 257 MB |  
|macos-aarch64 | 294 MB |  
|macos-x64 | 289 MB |  
|windows-x64 | 275 MB |

P.S. this also includes the pre-processor as a Maven library, so merging this PR will add processing:java:prepocessor as a Maven package

Fixes #924

@Stefterv
Copy link
Collaborator Author

Stefterv commented Jan 15, 2025

Windows arm64 compatibility seems to be in the current beta of compose desktop https://youtrack.jetbrains.com/issue/CMP-2584 so could be added as a support soon too

Requires Java 21!

@SableRaf

This comment was marked as outdated.

@Stefterv
Copy link
Collaborator Author

Screenshot 2025-01-25 at 10 23 51 Found an issue on Raspberry PI OS 64-bit where the text do not display

@Stefterv
Copy link
Collaborator Author

Screenshot 2025-01-25 at 11 10 11 Fixed

@SableRaf
Copy link
Collaborator

SableRaf commented Feb 1, 2025

The proposed visual update looks beautiful with the theme’s background color extending to the title bar. However, the contrast with the title text isn’t accessible in the current version. This will need adjustments to meet WCAG standards.

image image

It's even worse when the window is out of focus:
image

And some themes are worse than others:
image

Edit: Windows 10

On Windows 10, the title looks fine when focused but out of focus, the title (and buttons) are not readable.

image

image

@SableRaf
Copy link
Collaborator

SableRaf commented Feb 1, 2025

On Windows 10, switching theme doesn't immediately update the title bar color. A restart is necessary.

image

@Stefterv
Copy link
Collaborator Author

Stefterv commented Feb 3, 2025

The contrast issue on macOS can only be solved by forcing the application in light mode, as the color of the text of the title bar is controlled by the OS
Screenshot 2025-02-03 at 11 25 59
I will look into the windows issue further, it can also be fixed by opening a new editor window. As far as I understand the title bar there is not changable after instatiantion. We can either re-open the editor after changing of the theme or wait until we switch that part over to Jetpack Compose

- Disable system look & feel on macOS for readability
- Cleaned unnecessary space
- Cleaned finished TODO
@SableRaf
Copy link
Collaborator

SableRaf commented Feb 3, 2025

We can either re-open the editor after changing of the theme or wait until we switch that part over to Jetpack Compose

If that's not too much work, I'd say let's see how the re-opening of the editor feels.

Alternatively, how about we inform the user that the full change will take effect after they restart Processing? Could be a pop up message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

Create README for Running Non-production Builds
4 participants