Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not build against opencv 4.11 #138

Open
E1k3 opened this issue Jan 20, 2025 · 2 comments
Open

Does not build against opencv 4.11 #138

E1k3 opened this issue Jan 20, 2025 · 2 comments

Comments

@E1k3
Copy link

E1k3 commented Jan 20, 2025

openeb/sdk/modules/core/cpp/include/metavision/sdk/core/algorithms/roi_mask_algorithm.h:129:34: error: no matching function for call to ‘cv::Rect_<int>::contains(<brace-enclosed initializer list>) const’

Fix by replacing
return rectangle.contains({x, y});
with
return rectangle.contains(cv::Point{x, y});

@lbristiel-psee
Copy link
Collaborator

Thank you for the feedback! You’re right ,OpenEB is not currently compatible with OpenCV 4.11 as-is, and the change you mentioned would indeed be necessary to ensure compatibility. However, the installation guide for Ubuntu 22 and 24 specifies using the default OpenCV installation, which installs an older version (prior to 4.11). On those platforms, OpenEB compiles and functions as expected without issues. But your message will be useful for those trying to work with version 4.11.

@E1k3
Copy link
Author

E1k3 commented Jan 21, 2025

Not everyone is using Ubuntu and my suggested change does not break compatibility with older OpenCV versions, so why not just change one line and make it work for everyone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants