Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: provide a method of restoring allocated memory #4

Open
stephenmathieson opened this issue Dec 23, 2014 · 3 comments
Open

feature: provide a method of restoring allocated memory #4

stephenmathieson opened this issue Dec 23, 2014 · 3 comments

Comments

@stephenmathieson
Copy link

... seems pretty important :p

maybe something like:

json_free(json_value_t *)

or is the plan for json_destroy() to cleanup memory too?

this also needs to be implemented upstream (https://github.com/qute/qute/tree/wip/fix-memory-leaks)

@jwerle
Copy link
Member

jwerle commented Dec 23, 2014

json_destroy is meant to do that.. I justs forgot to put the call to free() back ;]

See cf939af

@stephenmathieson
Copy link
Author

haha okay makes sense.

when the memory stuff makes it into qute, json_destroy() will need to cleanup the parser/lexer/etc. too

@jwerle
Copy link
Member

jwerle commented Dec 23, 2014

yep totally !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants