Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layouts managment #20

Closed
danielwerg opened this issue Jan 18, 2025 · 2 comments
Closed

layouts managment #20

danielwerg opened this issue Jan 18, 2025 · 2 comments
Labels
enhancement New feature or request not yet planned Not planned but considering

Comments

@danielwerg
Copy link
Contributor

Just saw https://github.com/qxb3/fum/wiki/Rices section in wiki and while trying to apply them I run into couple issue/roadblocks:

  1. Missing players, use_active_player and debug

I would forget to add it myself and get stuck for couple seconds thinking whats wrong

  1. Having to type long path for config

Instead of fum -c ~/.config/fum/long_config_name.json, fum could also accept long_config_name and look for it in config dir

  1. width and height should be inside layout (maybe rename UI?)

Also few ideas how to improve the situation

a.

layout: accept string, name of the layout
layouts: array, each layout has a name

b.

Same as a. but have layouts in separate files. That way there would be config.json with layout and several layout-$NAME files along it.

@qxb3 qxb3 added the enhancement New feature or request label Jan 18, 2025
@qxb3
Copy link
Owner

qxb3 commented Jan 18, 2025

Just saw https://github.com/qxb3/fum/wiki/Rices section in wiki and while trying to apply them I run into couple issue/roadblocks:
Missing players, use_active_player and debug

  • Yeah i intentionally hid them so you just copy the layout important part. Feel free to add them tho if you want.

Having to type long path for config
Instead of fum -c ~/.config/fum/long_config_name.json, fum could also accept long_config_name and look for it in config dir width and height should be inside layout (maybe rename UI?)

Also few ideas how to improve the situation

a.

layout: accept string, name of the layout
layouts: array, each layout has a name

b.

Same as a. but have layouts in separate files. That way there would be config.json with layout and several layout-$NAME files along it.

  • Yeah having like a separate file for different layouts can be interesting. I also ran to this problem while screenshot-ing the project where i have to delete the current one to replace it with another one. I might consider this

config.json:

{
  "use_layout": "bar",
  "layouts": ["~/.config/fum/bar.json", "~/.config/fum/foo.json"]
}

bar.json:

{
  "name": "bar" // what will be used in use_layout
  ...
}

width and height should be inside layout (maybe rename UI?)

will do this when i decides to go with the above

@qxb3 qxb3 added the not yet planned Not planned but considering label Jan 20, 2025
@qxb3
Copy link
Owner

qxb3 commented Jan 27, 2025

After some time of consideration, i decided not to go with this as its i think unnecessary feature that most people don't want. I guess if someone wants to have a layouts management they could write a script to do it, Writing one should be really easy to do.

Especially now that im planning to make the config auto-reload when changed. #42

@qxb3 qxb3 closed this as completed Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request not yet planned Not planned but considering
Projects
None yet
Development

No branches or pull requests

2 participants