Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the installation steps more user-friendly #5

Open
anglixue opened this issue Mar 2, 2023 · 2 comments
Open

Make the installation steps more user-friendly #5

anglixue opened this issue Mar 2, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@anglixue
Copy link
Collaborator

anglixue commented Mar 2, 2023

I have summarized several points I think we can improve the user expression when installing the pre-requested packages.

  1. Shall we give instructions for pre-installed method packages? Like the following
# CiteFuse
if (!require("BiocManager", quietly = TRUE))
  install.packages("BiocManager")

BiocManager::install("CiteFuse")

# sc2marker
if (!require("devtools", quietly = TRUE))
  install.packages("devtools")
devtools::install_github("https://github.com/CostaLab/sc2marker", build_vignettes = TRUE)

# geneBasisR
devtools::install_github("MarioniLab/geneBasisR") 
  1. I remember on the readme page we have listed all four methods included in this package. What is the reason for removing it?

  2. When loading the library, check the required packages
    I can add those functions later

  3. Add links with the required packages in the readme pages. So users can directly go to the original websites
    https://www.bioconductor.org/packages/release/bioc/html/CiteFuse.html
    https://github.com/CostaLab/sc2marker
    https://github.com/MarioniLab/geneBasisR
    etc...

  4. When I run the code with the first method, 'CiteFuse', the following error occurred.

Error in loadNamespace(j <- i[[1L]], c(lib.loc, .libPaths()), versionCheck = vI[[j]]) : 
  there is no package called ‘propr’

I confirmed the package is properly installed. I checked the website and 'propr' should be imported from the package. Has anyone met this before?

  1. I've started a pull request where I add a function to check the user input method. Could anyone review it and merge into the main branch?
    Qc test #4

  2. At the end of the readme page, maybe print out your sessionInfo() so users will know about your development environment. Make sure you clear all your R environment and loaded packages before starting the whole pipeline, so you won't import some packages elsewhere unconsciously.

  3. I still have problems installing the package directly with the URL. This will be the first line of code that users will use. We might need to work it out to give a good first impression to users/reviewers.
    One reason could be this is still a private repository. After you make it public we could try again.

> devtools::install_github("raymondlouie/ClusterMarkers") 
Error: Failed to install 'unknown package' from GitHub:
  HTTP error 404.
  Not Found

  Did you spell the repo owner (`raymondlouie`) and repo name (`ClusterMarkers`) correctly?
  - If spelling is correct, check that you have the required permissions to access the repo.

We can discuss more in the meeting. Thank you!

@anglixue anglixue added the documentation Improvements or additions to documentation label Mar 2, 2023
@raymondlouie
Copy link
Owner

Thanks heaps Angli for the useful comments. I've should have implemented all of them, but please let me know if I forgot something.

@ghar1821
Copy link

ghar1821 commented Apr 1, 2023

Hi guys, just a suggestion. Rather than getting the users to install the dependencies themselves separately, you can perhaps change the DESCRIPTION file to automatically install those packages as dependencies.

So add something like the following to the DESCRIPTION file:

biocViews:
        CiteFuse
        SingleCellExperiment
Depends: R (>= 2.10)
Imports:
        Seurat
        xgboost
        dplyr
Remotes:
        tpq/propr
        CostaLab/sc2marker
        MarioniLab/geneBasisR
Suggests:
        devtools

Theoretically, the biocViews will automatically install packages from bioconductor, but I haven't test it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants