Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Tracing Granularity: Exclude Client-Side Processing from Command Duration #3149

Open
SimoneGiusso opened this issue Feb 1, 2025 · 1 comment
Labels
status: help-wanted An issue that a contributor can help us with status: waiting-for-triage
Milestone

Comments

@SimoneGiusso
Copy link

Feature Request

Is your feature request related to a problem? Please describe

This issue follows up on this discussion. Currently, the span reports the execution time of a single command, which includes not only network and Redis server processing but also client-side processing (e.g., serialization/deserialization). As a result, the generated trace lacks granularity, making it unclear whether high latencies are caused by slow application processing, external factors, or both.

For example, when analyzing slow HTTP requests, I sometimes see MGET Redis commands taking up to 750 ms. However, it's unclear how much of this time is actually spent on Redis versus client-side processing

Describe the solution you'd like

Client-side serialization/deserialization should either be excluded from the reported command duration or a more granular metric should be added. Ideally, the command duration should reflect:

Start time: The moment the command is issued from the client to the server.
End time: When the response is read from the socket, but before deserialization occurs.
This would provide a clearer picture of where time is spent and help diagnose latency issues more effectively.

Describe alternatives you've considered

N/A

Teachability, Documentation, Adoption, Migration Strategy

N/A

@tishun tishun added this to the Backlog milestone Feb 1, 2025
@tishun tishun added the status: help-wanted An issue that a contributor can help us with label Feb 1, 2025
@tishun
Copy link
Collaborator

tishun commented Feb 1, 2025

Thanks you for filing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help-wanted An issue that a contributor can help us with status: waiting-for-triage
Projects
None yet
Development

No branches or pull requests

2 participants