-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable event detection #26
Comments
I guess so but you checked that it is not saved in |
One can always do event detection after running a system between [0,t], but for efficiency, it's probably best to check the condition each time step, then interpolate only between two consecutive timesteps. |
Yes. I am not very keen on event detection but one can probably hack it. Did yu check lsoda_common_t? |
Yes, but one should probably have an interface to the one-step solver stoda in order to facilitate the common interface for event handling. |
Well, what we have here is currently enough since it's already controlled a stepwise level and I believe the GC works now? What stopped Sundials is that, in order for the GC to register the size, it needs a custom allocator, and so setting up the My plan there is to just take what's in the SciML/Sundials.jl#109 (comment) The rootfinding algorithm that comes in "the standard timestepping packages" isn't very good... and since we have Julia we can rely on the fact that our native methods are just as fast and put something more robust there which just uses the already existing interval interpolations. That said... I need to do my advancement right now so I won't be able to do this for awhile. |
Is the call to the intermediate interpolation wrapped? |
This issue is mostly to @ChrisRackauckas ; I'd like to use event detection in LSODA.jl; I assume that this will require some additions to liblsoda in order to support returning from lsoda every timestep?
The text was updated successfully, but these errors were encountered: