Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebLinks] [iOS] Links to the web app are outdated #3297

Closed
katspaugh opened this issue Aug 14, 2023 · 5 comments
Closed

[WebLinks] [iOS] Links to the web app are outdated #3297

katspaugh opened this issue Aug 14, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@katspaugh
Copy link
Member

katspaugh commented Aug 14, 2023

Original request
In the web app, we switched from URLs like /eth:0x1234/transactions to /transactions?safe=eth:0x1234.
I.e. the chain:address part is now a query parameter instead of a part of the path.

The old URLs will still work in the foreseeable future, as they are redirected, but they pollute our page view analytics. So ideally, please switch to the new format.

Sub-items

@DmitryBespalov
Copy link
Contributor

@DmitryBespalov
Copy link
Contributor

DmitryBespalov commented Aug 17, 2023

Routes

Variables

safe-address = chain-prefix : checksummed-address

chain-prefix = short name of a chain, such as 'eth', 'matic' or 'gno',
    according to the https://safe-client.safe.global/v1/chains 'shortName' field

checksummed-address = ethereum & evm-chain address in a hexadecimal, 
    checksummed format according to https://eips.ethereum.org/EIPS/eip-55

transaction-id = transaction identifier string

Legacy web app → mobile app routes

/safe-address/balancesAssets Tab - Balances

/safe-address/transactionsTransactions Tab - History
/safe-address/transactions/historyTransactions Tab - History
/safe-address/transactions/queueTransactions Tab - Queue
/safe-address/transactions/transaction-idModal Transaction Details

Current web app → mobile app routes

Onboarding and Home

/welcomeAssets Tab
start page

/home?safe=safe-addressAssets Tab
home / dashboard

/new-safe/loadModal Load Existing Safe
load new safe flow

/new-safe/createModal Create Safe
create new safe flow

Assets

/balances?safe=safe-addressAssets Tab - Coins
assets of a safe

/balances/nfts?safe=safe-addressAssets Tab - Collectibles
nfts of a safe

Transactions

/transactions?safe=safe-addressTransactions Tab - Queue
redirects to transaction queue

/transactions/history?safe=safe-addressTransactions Tab - History
history of past safe transactions

/transactions/queue?safe=safe-addressTransactions Tab - Queue
queue of staged safe transactions

/transactions/messages?safe=safe-addressTransactions Tab
signed messages

/transactions/tx?safe=safe-address&id=transaction-idModal Transaction Details
transaction details

Add Owner

/addOwner?safe=safe-address&address=new-owner-addressModal Update Owner From Invite Link flow
form to add new owner address

new-owner-address = checksummed-address

Safe Settings

/settings?safe=safe-addressSettings Tab - App Settings
main settings page

/settings/setup?safe=safe-addressSettings Tab - My Safe Account (safe settings)
safe nonce, owners, confirmations, delegates, contract version

/settings/appearance?safe=safe-addressSettings Tab - App Settings - Appearance
enable 3770 chain prefix
theme light/dark

/settings/modules?safe=safe-addressSettings Tab - My Safe Account - Advanced
addresses of modules
address of fallback handler

/settings/spending-limits?safe=safe-addressSettings Tab - My Safe Account
configured spending limits
(not implemented in the app)

/settings/safe-apps?safe=safe-addressdApps Tab
safe apps permissions, signing method off-chain
(not implemented in the app)

/settings/data?safe=safe-addressSettings Tab - App Settings
data export and import
(not implemented in the app)

/settings/environment-variables?safe=safe-addressSettings Tab - App Settings
API urls for RPC provider (infura) and Tenderly
(not implemented in the app)

/settings/cookies?safe=safe-addressSettings Tab - App Settings - Advanced
not accessible from web UI
cookie & tracking preferences

/address-book?safe=safe-addressSettings Tab - App Settings - Address Book
address book list with import/export and editing

Safe apps

/apps?safe=safe-addressdApps Tab
safe apps
(not implemented in the app)

/share/safe-app?appUrl=safe-app-url-encoded&chain=chain-prefixdApps Tab
share the safe app
(not implemented in the app)

Legal info

/termsSettings Tab - App Settings - About Safe{Wallet} - Terms of use
terms and conditions

/privacySettings Tab - App Settings - About Safe{Wallet} - Privacy policy
privacy policy

/licensesSettings Tab - App Settings - About Safe{Wallet} - Licenses
software licenses information

/imprintSettings Tab - App Settings - About Safe{Wallet}
legal contact & disclaimer information
(not implemented in the app)

/cookieSettings Tab - App Settings - About Safe{Wallet}
cookie policy
(not implemented in the app)

@DmitryBespalov
Copy link
Contributor

Legacy URIs have variables embedded in the path components. Current URIs use query items.

@DmitryBespalov DmitryBespalov added enhancement New feature or request Requirements missing and removed bug Doesn't work as expected Requirements missing labels Aug 17, 2023
DmitryBespalov added a commit that referenced this issue Aug 21, 2023
- Keep supporting previous format
- Added tests
@DmitryBespalov
Copy link
Contributor

Would be good to add integration tests for the web app url format, so that it would indicate the change in urls when it happened

DmitryBespalov added a commit that referenced this issue Aug 22, 2023
DmitryBespalov added a commit that referenced this issue Aug 22, 2023
@DmitryBespalov DmitryBespalov changed the title [iOS] Links to the web app are outdated [WebLinks] [iOS] Links to the web app are outdated Aug 23, 2023
MouazAlzahabi added a commit that referenced this issue Aug 23, 2023
DmitryBespalov added a commit that referenced this issue Aug 23, 2023
@liliya-soroka
Copy link
Member

All tickets from the Epic passed QA

app version 3.23.0 (1960)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants