Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3418 created basic export and import of data #3419

Merged
merged 6 commits into from
Jun 7, 2024

Conversation

DmitryBespalov
Copy link
Contributor

@DmitryBespalov DmitryBespalov commented May 30, 2024

Handles #3418

Changes proposed in this pull request:

  • Exporting safe list, owner key list, and address book
  • Exported file is encrypted with user-provided password
  • Importing the same data in the app, skipping duplicates
  • Errors are logged and presented to the user
  • Access in the App Settings - Export Data and App Settings - Import Data
  • Requires app passcode to export or import

* Exporting safe list, owner key list, and address book
* Exported file is encrypted with a random password
* Importing the same data in the app, skipping duplicates
* Access in App Settings, basic user interface
@DmitryBespalov DmitryBespalov self-assigned this May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 749 lines in your changes missing coverage. Please review.

Project coverage is 8.11%. Comparing base (4cf664a) to head (9c87319).
Report is 13 commits behind head on main.

Files Patch % Lines
...tures/Data Export/ImportExportDataController.swift 0.00% 377 Missing ⚠️
...ta Export/CreateExportPasswordViewController.swift 0.00% 84 Missing ⚠️
Multisig/Features/Data Export/ExportDataFlow.swift 0.00% 75 Missing ⚠️
Multisig/Features/Data Export/ImportDataFlow.swift 0.00% 64 Missing ⚠️
...res/Data Export/SelectDataFileViewController.swift 0.00% 30 Missing ⚠️
...ingsViewController/AppSettingsViewController.swift 0.00% 25 Missing ⚠️
Multisig/Logic/Models/KeyInfo.swift 0.00% 23 Missing ⚠️
...s/Data Export/ExportInProgressViewController.swift 0.00% 22 Missing ⚠️
...s/Data Export/ImportInProgressViewController.swift 0.00% 19 Missing ⚠️
...sig/Features/Data Export/ErrorViewController.swift 0.00% 18 Missing ⚠️
... and 2 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3419      +/-   ##
========================================
- Coverage   8.25%   8.11%   -0.14%     
========================================
  Files        788     796       +8     
  Lines      44210   44953     +743     
========================================
  Hits        3648    3648              
- Misses     40562   41305     +743     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmitryBespalov DmitryBespalov merged commit 9346226 into main Jun 7, 2024
2 of 4 checks passed
@DmitryBespalov DmitryBespalov deleted the GH-3418/export-data branch June 7, 2024 08:36
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant