Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special characters split a word into several words #8

Open
erreurBarbare opened this issue Jun 29, 2022 · 2 comments
Open

Special characters split a word into several words #8

erreurBarbare opened this issue Jun 29, 2022 · 2 comments
Labels
approved Approved for implementation bug Something isn't working

Comments

@erreurBarbare
Copy link

First of all: I really love Serenade! Is so easy to use and I can relax my aching hands. Thank you so much for that.

System Information

Serenade Version: v2.0.1

OS and Version: Windows Version 10.0.19043 Build 19043

Application: Chrome, VS Code

Issue Description

In German, words may contain umlauts (äöü).
Serenade does recognize them as separate words, such as other special characters (e.g. $, ., etc.).
Thus, commands such as 'call write 5 words' or 'delete 3 words' does actually delete less words than indicated.

How to Reproduce

(I tried with Chrome and VS Code)

  1. Insert this text: 'Ich bin glücklich.'
  2. Use the command 'go left 1 word' 3 times

Result: as characters are recognized as separate words, a word with a umlaut will be recognized as multiple words

@erreurBarbare erreurBarbare added bug Something isn't working needs-triage Awaiting triage from a core team member labels Jun 29, 2022
@MattWiethoff MattWiethoff added approved Approved for implementation and removed needs-triage Awaiting triage from a core team member labels Jul 9, 2022
@MattWiethoff
Copy link
Contributor

MattWiethoff commented Jul 9, 2022

Thanks for the report. The fix is likely just going to be updating this regex and the corresponding yaml tests:

filterByName(filterByLine(regexMatch("[a-zA-Z0-9_]+|[^\\sa-zA-Z0-9_]+")))

@erreurBarbare
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for implementation bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants