Allow negative values for --display-offset
#145
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--display-offset
has had an odd relationship with negated inputs over its lifetime. Historical behaviors (and the addition being proposed here) might be easiest to understand in a tabular format.xxd
desired, made an offset of--skip
in #119.--skip
.This PR proposes to make negative values for
--display-offset
meaningful again by allowing them again when--skip
is specified, adding a negative value to--skip
if provided. To use the same format as above:--skip
.--skip
is specified; underflow results in an error.More detailed overview of the design and rationale:
This stays consistent with current behavior -- the final display offset retains its concept as "
--skip
+--display-offset
".This adds an error case for the display offset underflowing when added to the unsigned
--skip
offset:Bonus: the error case where offset addition overflows now has a nice diagnostic:
If
--skip
is not specified, it is an error, as before:Resolves #112.
PR checklist: