Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port lambda compilation to original NCalc as plugin #112

Open
Bykiev opened this issue May 27, 2024 · 7 comments
Open

Port lambda compilation to original NCalc as plugin #112

Bykiev opened this issue May 27, 2024 · 7 comments

Comments

@Bykiev
Copy link
Contributor

Bykiev commented May 27, 2024

The original NCalc version was moved to Parlot parser. Now the DI and Plugins are supported. As many features are just backported here I'd suggest to implement the core feature - compilation of expression to CLR Lambda as Plugin.

@david-brink-talogy, @sklose what do you think?

@david-brink-talogy
Copy link
Collaborator

It would be great if the ncalc community could unite behind a single implementation. Having ncalc/ncalc, sklose/ncalc2, and ncalc/ncalc-async causes confuses which is apparent on some of the issue boards in the various repos.

I think this repo adds more than support for linq expressions. The difference in the EvaluationOptions might be a reasonable place to start.
https://github.com/sklose/NCalc2/blob/master/src/NCalc/EvaluationOption.cs
https://github.com/ncalc/ncalc/blob/master/src/NCalc/ExpressionOptions.cs

@Bykiev
Copy link
Contributor Author

Bykiev commented May 30, 2024

There are some difference between NCalc and NCalc2 with EvaluationOptions (now it's ExpressionOptions), welcome to contribute ncalc/ncalc#188 !

@sklose
Copy link
Owner

sklose commented Jun 2, 2024

@Bykiev @david-brink-talogy looks like the PR ncalc/ncalc#188 is about to land. What do you think should be the future of this project? It seems all features that were added here have been ported. I am leaning towards archiving the project and updating the README file with a pointer to ncalc/ncalc. Does anybody see any value in keeping this project alive?

@Bykiev
Copy link
Contributor Author

Bykiev commented Jun 2, 2024

I think after the release of NCalc v4.2 we should create a note in NCalc2 repo, that all features are ported to NCalcSync package and users should migrate to this package. I'm expecting some minor issues during migration process (there are some differences in packages). And when it'll be stable, the NCalc2 project can be archived.

@david-brink-talogy
Copy link
Collaborator

Might be good to get insight from the PanoramicData team since it has a dependency on this package. Unfortunately it doesn't seem like I can properly mention @davidnmbond.

@Bykiev
Copy link
Contributor Author

Bykiev commented Jun 4, 2024

PanoramicData still using v2.2.110

@Bykiev
Copy link
Contributor Author

Bykiev commented Jul 1, 2024

As all features from NCalc2 were moved to NCalc project this repo can be archived. Welcome to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants