From 28ee451933adcc2a3c81863f57961d0c3251fb73 Mon Sep 17 00:00:00 2001 From: Kazuhiro Sera Date: Wed, 15 Jan 2025 07:07:09 +0900 Subject: [PATCH] Apply suggestions from code review Co-authored-by: William Bergamin --- .../api/bolt/service/builtin/AmazonS3InstallationService.java | 2 +- .../api/bolt/service/builtin/AmazonS3OAuthStateService.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bolt/src/main/java/com/slack/api/bolt/service/builtin/AmazonS3InstallationService.java b/bolt/src/main/java/com/slack/api/bolt/service/builtin/AmazonS3InstallationService.java index a067a0cd2..fd86657c2 100644 --- a/bolt/src/main/java/com/slack/api/bolt/service/builtin/AmazonS3InstallationService.java +++ b/bolt/src/main/java/com/slack/api/bolt/service/builtin/AmazonS3InstallationService.java @@ -51,7 +51,7 @@ public AmazonS3InstallationService( ) { this.bucketName = bucketName; this.credentialsProvider = credentialsProvider; - this.region = region != null || System.getenv("AWS_REGION") == null ? region : Region.of(System.getenv("AWS_REGION")); + this.region = (region != null || System.getenv("AWS_REGION") == null) ? region : Region.of(System.getenv("AWS_REGION")); this.endpointOverride = (endpointOverride != null && !endpointOverride.isEmpty()) ? URI.create(endpointOverride) : null; } diff --git a/bolt/src/main/java/com/slack/api/bolt/service/builtin/AmazonS3OAuthStateService.java b/bolt/src/main/java/com/slack/api/bolt/service/builtin/AmazonS3OAuthStateService.java index b7dbe63b2..d6e77c18f 100644 --- a/bolt/src/main/java/com/slack/api/bolt/service/builtin/AmazonS3OAuthStateService.java +++ b/bolt/src/main/java/com/slack/api/bolt/service/builtin/AmazonS3OAuthStateService.java @@ -45,7 +45,7 @@ public AmazonS3OAuthStateService( ) { this.bucketName = bucketName; this.credentialsProvider = credentialsProvider; - this.region = region != null || System.getenv("AWS_REGION") == null ? region : Region.of(System.getenv("AWS_REGION")); + this.region = (region != null || System.getenv("AWS_REGION") == null) ? region : Region.of(System.getenv("AWS_REGION")); this.endpointOverride = (endpointOverride != null && !endpointOverride.isEmpty()) ? URI.create(endpointOverride) : null; }