From 030e3f035e329ac8ea1d074a1207ea11151920ac Mon Sep 17 00:00:00 2001 From: Marco Carlino Date: Fri, 13 Dec 2024 18:09:32 +0100 Subject: [PATCH 1/2] add impala --- pytest.ini | 1 + requirements.txt | 1 + soda/impala/LICENSE | 201 ++++++++++++++++++ soda/impala/setup.py | 16 ++ .../soda/data_sources/impala_data_source.py | 129 +++++++++++ soda/impala/tests/docker/config/hive-site.xml | 74 +++++++ soda/impala/tests/docker/docker-compose.yaml | 91 ++++++++ .../tests/impala_data_source_fixture.py | 32 +++ soda/impala/tests/test_impala.py | 2 + soda/impala/tests/test_impala_connection.py | 29 +++ tbump.toml | 4 + 11 files changed, 580 insertions(+) create mode 100644 soda/impala/LICENSE create mode 100644 soda/impala/setup.py create mode 100644 soda/impala/soda/data_sources/impala_data_source.py create mode 100644 soda/impala/tests/docker/config/hive-site.xml create mode 100644 soda/impala/tests/docker/docker-compose.yaml create mode 100644 soda/impala/tests/impala_data_source_fixture.py create mode 100644 soda/impala/tests/test_impala.py create mode 100644 soda/impala/tests/test_impala_connection.py diff --git a/pytest.ini b/pytest.ini index d5788bdbb..cbb38a496 100644 --- a/pytest.ini +++ b/pytest.ini @@ -25,3 +25,4 @@ pythonpath = soda/contracts/tests soda/oracle/tests soda/fabric/tests + soda/impala/tests diff --git a/requirements.txt b/requirements.txt index 3cfd16eba..280274771 100644 --- a/requirements.txt +++ b/requirements.txt @@ -23,3 +23,4 @@ ./soda/contracts ./soda/atlan ./soda/fabric +./soda/impala diff --git a/soda/impala/LICENSE b/soda/impala/LICENSE new file mode 100644 index 000000000..261eeb9e9 --- /dev/null +++ b/soda/impala/LICENSE @@ -0,0 +1,201 @@ + Apache License + Version 2.0, January 2004 + http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, + and distribution as defined by Sections 1 through 9 of this document. + + "Licensor" shall mean the copyright owner or entity authorized by + the copyright owner that is granting the License. + + "Legal Entity" shall mean the union of the acting entity and all + other entities that control, are controlled by, or are under common + control with that entity. For the purposes of this definition, + "control" means (i) the power, direct or indirect, to cause the + direction or management of such entity, whether by contract or + otherwise, or (ii) ownership of fifty percent (50%) or more of the + outstanding shares, or (iii) beneficial ownership of such entity. + + "You" (or "Your") shall mean an individual or Legal Entity + exercising permissions granted by this License. + + "Source" form shall mean the preferred form for making modifications, + including but not limited to software source code, documentation + source, and configuration files. + + "Object" form shall mean any form resulting from mechanical + transformation or translation of a Source form, including but + not limited to compiled object code, generated documentation, + and conversions to other media types. + + "Work" shall mean the work of authorship, whether in Source or + Object form, made available under the License, as indicated by a + copyright notice that is included in or attached to the work + (an example is provided in the Appendix below). + + "Derivative Works" shall mean any work, whether in Source or Object + form, that is based on (or derived from) the Work and for which the + editorial revisions, annotations, elaborations, or other modifications + represent, as a whole, an original work of authorship. For the purposes + of this License, Derivative Works shall not include works that remain + separable from, or merely link (or bind by name) to the interfaces of, + the Work and Derivative Works thereof. + + "Contribution" shall mean any work of authorship, including + the original version of the Work and any modifications or additions + to that Work or Derivative Works thereof, that is intentionally + submitted to Licensor for inclusion in the Work by the copyright owner + or by an individual or Legal Entity authorized to submit on behalf of + the copyright owner. For the purposes of this definition, "submitted" + means any form of electronic, verbal, or written communication sent + to the Licensor or its representatives, including but not limited to + communication on electronic mailing lists, source code control systems, + and issue tracking systems that are managed by, or on behalf of, the + Licensor for the purpose of discussing and improving the Work, but + excluding communication that is conspicuously marked or otherwise + designated in writing by the copyright owner as "Not a Contribution." + + "Contributor" shall mean Licensor and any individual or Legal Entity + on behalf of whom a Contribution has been received by Licensor and + subsequently incorporated within the Work. + + 2. Grant of Copyright License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + copyright license to reproduce, prepare Derivative Works of, + publicly display, publicly perform, sublicense, and distribute the + Work and such Derivative Works in Source or Object form. + + 3. Grant of Patent License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + (except as stated in this section) patent license to make, have made, + use, offer to sell, sell, import, and otherwise transfer the Work, + where such license applies only to those patent claims licensable + by such Contributor that are necessarily infringed by their + Contribution(s) alone or by combination of their Contribution(s) + with the Work to which such Contribution(s) was submitted. If You + institute patent litigation against any entity (including a + cross-claim or counterclaim in a lawsuit) alleging that the Work + or a Contribution incorporated within the Work constitutes direct + or contributory patent infringement, then any patent licenses + granted to You under this License for that Work shall terminate + as of the date such litigation is filed. + + 4. Redistribution. You may reproduce and distribute copies of the + Work or Derivative Works thereof in any medium, with or without + modifications, and in Source or Object form, provided that You + meet the following conditions: + + (a) You must give any other recipients of the Work or + Derivative Works a copy of this License; and + + (b) You must cause any modified files to carry prominent notices + stating that You changed the files; and + + (c) You must retain, in the Source form of any Derivative Works + that You distribute, all copyright, patent, trademark, and + attribution notices from the Source form of the Work, + excluding those notices that do not pertain to any part of + the Derivative Works; and + + (d) If the Work includes a "NOTICE" text file as part of its + distribution, then any Derivative Works that You distribute must + include a readable copy of the attribution notices contained + within such NOTICE file, excluding those notices that do not + pertain to any part of the Derivative Works, in at least one + of the following places: within a NOTICE text file distributed + as part of the Derivative Works; within the Source form or + documentation, if provided along with the Derivative Works; or, + within a display generated by the Derivative Works, if and + wherever such third-party notices normally appear. The contents + of the NOTICE file are for informational purposes only and + do not modify the License. You may add Your own attribution + notices within Derivative Works that You distribute, alongside + or as an addendum to the NOTICE text from the Work, provided + that such additional attribution notices cannot be construed + as modifying the License. + + You may add Your own copyright statement to Your modifications and + may provide additional or different license terms and conditions + for use, reproduction, or distribution of Your modifications, or + for any such Derivative Works as a whole, provided Your use, + reproduction, and distribution of the Work otherwise complies with + the conditions stated in this License. + + 5. Submission of Contributions. Unless You explicitly state otherwise, + any Contribution intentionally submitted for inclusion in the Work + by You to the Licensor shall be under the terms and conditions of + this License, without any additional terms or conditions. + Notwithstanding the above, nothing herein shall supersede or modify + the terms of any separate license agreement you may have executed + with Licensor regarding such Contributions. + + 6. Trademarks. This License does not grant permission to use the trade + names, trademarks, service marks, or product names of the Licensor, + except as required for reasonable and customary use in describing the + origin of the Work and reproducing the content of the NOTICE file. + + 7. Disclaimer of Warranty. Unless required by applicable law or + agreed to in writing, Licensor provides the Work (and each + Contributor provides its Contributions) on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or + implied, including, without limitation, any warranties or conditions + of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A + PARTICULAR PURPOSE. You are solely responsible for determining the + appropriateness of using or redistributing the Work and assume any + risks associated with Your exercise of permissions under this License. + + 8. Limitation of Liability. In no event and under no legal theory, + whether in tort (including negligence), contract, or otherwise, + unless required by applicable law (such as deliberate and grossly + negligent acts) or agreed to in writing, shall any Contributor be + liable to You for damages, including any direct, indirect, special, + incidental, or consequential damages of any character arising as a + result of this License or out of the use or inability to use the + Work (including but not limited to damages for loss of goodwill, + work stoppage, computer failure or malfunction, or any and all + other commercial damages or losses), even if such Contributor + has been advised of the possibility of such damages. + + 9. Accepting Warranty or Additional Liability. While redistributing + the Work or Derivative Works thereof, You may choose to offer, + and charge a fee for, acceptance of support, warranty, indemnity, + or other liability obligations and/or rights consistent with this + License. However, in accepting such obligations, You may act only + on Your own behalf and on Your sole responsibility, not on behalf + of any other Contributor, and only if You agree to indemnify, + defend, and hold each Contributor harmless for any liability + incurred by, or claims asserted against, such Contributor by reason + of your accepting any such warranty or additional liability. + + END OF TERMS AND CONDITIONS + + APPENDIX: How to apply the Apache License to your work. + + To apply the Apache License to your work, attach the following + boilerplate notice, with the fields enclosed by brackets "[]" + replaced with your own identifying information. (Don't include + the brackets!) The text should be enclosed in the appropriate + comment syntax for the file format. We also recommend that a + file or class name and description of purpose be included on the + same "printed page" as the copyright notice for easier + identification within third-party archives. + + Copyright [yyyy] [name of copyright owner] + + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. diff --git a/soda/impala/setup.py b/soda/impala/setup.py new file mode 100644 index 000000000..415c93f69 --- /dev/null +++ b/soda/impala/setup.py @@ -0,0 +1,16 @@ +#!/usr/bin/env python + +from setuptools import find_namespace_packages, setup + +package_name = "soda-core-impala" +package_version = "3.4.3" +description = "Soda Core Impala Package" + +requires = [f"soda-core=={package_version}", "impyla==0.19.0"] +# TODO Fix the params +setup( + name=package_name, + version=package_version, + install_requires=requires, + packages=find_namespace_packages(include=["soda*"]), +) diff --git a/soda/impala/soda/data_sources/impala_data_source.py b/soda/impala/soda/data_sources/impala_data_source.py new file mode 100644 index 000000000..4c720555b --- /dev/null +++ b/soda/impala/soda/data_sources/impala_data_source.py @@ -0,0 +1,129 @@ +import logging +import re +from typing import Union + +from soda.common.logs import Logs +from soda.execution.data_source import DataSource +from soda.execution.data_type import DataType + +logger = logging.getLogger(__name__) + + +class ImpalaDataSource(DataSource): + SCHEMA_CHECK_TYPES_MAPPING: dict = { + "string": ["varchar", "char"], + "int": ["integer", "int"], + } + SQL_TYPE_FOR_CREATE_TABLE_MAP: dict = { + DataType.TEXT: "string", + DataType.INTEGER: "int", + DataType.DECIMAL: "decimal", + DataType.DATE: "timestamp", # No date support in Impala + DataType.TIME: "timestamp", + DataType.TIMESTAMP: "timestamp", + DataType.TIMESTAMP_TZ: "timestamp", # No timezone support in Impala + DataType.BOOLEAN: "boolean", + } + + SQL_TYPE_FOR_SCHEMA_CHECK_MAP = { + DataType.TEXT: "string", + DataType.INTEGER: "int", + DataType.DECIMAL: "decimal", + DataType.DATE: "timestamp", # No date support in Impala + DataType.TIME: "timestamp", + DataType.TIMESTAMP: "timestamp", + DataType.TIMESTAMP_TZ: "timestamp", # No timezone support in Impala + DataType.BOOLEAN: "boolean", + } + + NUMERIC_TYPES_FOR_PROFILING = [ + "int", + "bigint", + "smallint", + "tinyint", + "double", + "float", + "decimal", + ] + TEXT_TYPES_FOR_PROFILING = ["string", "varchar", "char"] + + def __init__(self, logs: Logs, data_source_name: str, data_source_properties: dict): + super().__init__(logs, data_source_name, data_source_properties) + self.host = data_source_properties.get("host") + self.port = data_source_properties.get("port") + self.username = data_source_properties.get("username") + self.password = data_source_properties.get("password") + self.http_path = data_source_properties.get("http_path", None) + self.use_http_transport = data_source_properties.get("use_http_transport", False) + self.use_ssl = data_source_properties.get("use_ssl", False) + self.auth_mechanism = data_source_properties.get("auth_mechanism", None) + + def connect(self): + import impala.dbapi + + if isinstance(self.host, str) and len(self.host) > 0: + self.connection = impala.dbapi.connect( + host=self.host, + user=self.username, + password=self.password, + http_path=self.http_path, + use_http_transport=self.use_http_transport, + use_ssl=self.use_ssl, + auth_mechanism=self.auth_mechanism, + port=self.port, + database=self.database + ) + else: + raise ConnectionError( + f"Invalid impala connection properties: invalid host: {self.host}" + ) + return self.connection + + def safe_connection_data(self): + return [ + self.type, + self.host, + self.port, + self.database, + ] + + def sql_get_table_columns( + self, + table_name: str, + included_columns: Union[list[str], None] = None, + excluded_columns: Union[list[str], None] = None, + ): + return f"DESCRIBE {table_name}" + + def sql_find_table_names( + self, + filter: Union[str, None] = None, + include_tables: list[str] = [], + exclude_tables: list[str] = [], + table_column_name: str = "table_name", + schema_column_name: str = "table_schema", + ) -> str: + from_clause = f" FROM {self.database}" if self.database else "" + return f"SHOW TABLES{from_clause}" + + def sql_get_table_names_with_count( + self, + include_tables: Union[list[str], None] = None, + exclude_tables: Union[list[str], None] = None + ) -> str: + return "" + + def regex_replace_flags(self) -> str: + return "" + + def escape_regex(self, value: str): + return re.sub(r"(\\.)", r"\\\1", value) + + def default_casify_table_name(self, identifier: str) -> str: + return identifier.lower() + + def quote_table(self, table_name) -> str: + return f"`{table_name}`" + + def quote_column(self, column_name: str) -> str: + return f"`{column_name}`" diff --git a/soda/impala/tests/docker/config/hive-site.xml b/soda/impala/tests/docker/config/hive-site.xml new file mode 100644 index 000000000..100fd9fc8 --- /dev/null +++ b/soda/impala/tests/docker/config/hive-site.xml @@ -0,0 +1,74 @@ + + + + + + + + hive.metastore.dml.events + true + + + + hive.metastore.event.db.notification.api.auth + false + + + hive.metastore.uris + thrift://quickstart-hive-metastore:9083 + + + + hive.metastore.warehouse.dir + /user/hive/warehouse/managed + + + hive.metastore.warehouse.external.dir + /user/hive/warehouse/external + + + + hive.support.concurrency + true + + + + hive.txn.manager + org.apache.hadoop.hive.ql.lockmgr.DbTxnManager + + + + javax.jdo.option.ConnectionDriverName + org.apache.derby.jdbc.EmbeddedDriver + + + + javax.jdo.option.ConnectionURL + jdbc:derby:;databaseName=/var/lib/hive/metastore/metastore_db;create=true + + + + hive.stats.autogather + false + + \ No newline at end of file diff --git a/soda/impala/tests/docker/docker-compose.yaml b/soda/impala/tests/docker/docker-compose.yaml new file mode 100644 index 000000000..b201757bf --- /dev/null +++ b/soda/impala/tests/docker/docker-compose.yaml @@ -0,0 +1,91 @@ +services: + hms: + image: ${IMPALA_QUICKSTART_IMAGE_PREFIX:-apache/impala:4.4.1-}impala_quickstart_hms + # Give the HMS an explicit hostname to avoid issues with docker-compose-generated + # hostnames including underscore, which is rejected by Java's URL parser. + container_name: quickstart-hive-metastore + command: ["hms"] + volumes: + # Volume used to store Apache Derby database. + - impala-quickstart-warehouse:/var/lib/hive + # Warehouse directory. HMS does file operations so needs access to the + # shared volume. + - impala-quickstart-warehouse:/user/hive/warehouse + - ./config:/opt/hive/conf:ro + networks: + - quickstart-network + statestored: + image: ${IMPALA_QUICKSTART_IMAGE_PREFIX:-apache/impala:4.4.1-}statestored + ports: + # Web debug UI + - "0.0.0.0:25010:25010" + command: ["-redirect_stdout_stderr=false", "-logtostderr", "-v=1"] + volumes: + - ./config:/opt/impala/conf:ro + networks: + - quickstart-network + catalogd: + depends_on: + - statestored + - hms + image: ${IMPALA_QUICKSTART_IMAGE_PREFIX:-apache/impala:4.4.1-}catalogd + ports: + # Web debug UI + - "0.0.0.0:25020:25020" + command: ["-redirect_stdout_stderr=false", "-logtostderr", "-v=1", + "-hms_event_polling_interval_s=1", "-invalidate_tables_timeout_s=999999"] + volumes: + # Warehouse directory. Catalog does file operations so needs access to the + # shared volume. + - impala-quickstart-warehouse:/user/hive/warehouse + - ./config:/opt/impala/conf:ro + networks: + - quickstart-network + impalad-1: + image: ${IMPALA_QUICKSTART_IMAGE_PREFIX:-apache/impala:4.4.1-}impalad_coord_exec + container_name: docker_impalad-1_1 + depends_on: + - statestored + - catalogd + ports: + # Beeswax endpoint (deprecated) + #- "0.0.0.0:21000:21000" + # HS2 endpoint + - "0.0.0.0:21050:21050" + # Web debug UI + - "0.0.0.0:25000:25000" + # HS2 over HTTP endpoint. + - "0.0.0.0:28000:28000" + command: [ "-v=1", + "-redirect_stdout_stderr=false", "-logtostderr", + "-kudu_master_hosts=kudu-master-1:7051", + "-mt_dop_auto_fallback=true", + "-default_query_options=mt_dop=4,default_file_format=parquet,default_transactional_type=insert_only", + "-mem_limit=4gb"] + environment: + # Keep the Java heap small to preserve memory for query execution. + - JAVA_TOOL_OPTIONS="-Xmx1g" + volumes: + - impala-quickstart-warehouse:/user/hive/warehouse + - ./config:/opt/impala/conf:ro + networks: + - quickstart-network + data-loader: + image: ${IMPALA_QUICKSTART_IMAGE_PREFIX:-apache/impala:4.4.1-}impala_quickstart_client + depends_on: + - impalad-1 + command: ["load_tpcds"] + volumes: + - impala-quickstart-warehouse:/user/hive/warehouse + - ./config:/opt/impala/conf:ro + networks: + - quickstart-network + +volumes: + impala-quickstart-hms: + impala-quickstart-warehouse: + +networks: + quickstart-network: + name: quickstart-network + driver: bridge diff --git a/soda/impala/tests/impala_data_source_fixture.py b/soda/impala/tests/impala_data_source_fixture.py new file mode 100644 index 000000000..0003a32e1 --- /dev/null +++ b/soda/impala/tests/impala_data_source_fixture.py @@ -0,0 +1,32 @@ +from __future__ import annotations + +import logging +import os + +from helpers.data_source_fixture import DataSourceFixture, is_cicd + +logger = logging.getLogger(__name__) + + +class ImpalaDataSourceFixture(DataSourceFixture): + def __init__(self, test_data_source: str): + super().__init__(test_data_source=test_data_source) + + def _build_configuration_dict(self, schema_name: str | None = None) -> dict: + return { + "data_source impala": { + "type": "impala", + "host": os.getenv("IMPALA_HOST", "localhost"), + #"username": os.getenv("IMPALA_USERNAME", "impala"), + #"password": os.getenv("IMPALA_PASSWORD"), + #"database": os.getenv("IMPALA_DATABASE", "default"), + "port": int(os.getenv("IMPALA_PORT", "21050")), + "auth_mechanism": "NOSASL", + } + } + + def _create_schema_if_not_exists_sql(self): + return f"CREATE SCHEMA IF NOT EXISTS {self.schema_name}" + + def _drop_schema_if_exists_sql(self): + return f"DROP SCHEMA IF EXISTS {self.schema_name}" diff --git a/soda/impala/tests/test_impala.py b/soda/impala/tests/test_impala.py new file mode 100644 index 000000000..f15c30fe7 --- /dev/null +++ b/soda/impala/tests/test_impala.py @@ -0,0 +1,2 @@ +def test_impala(): + """Add plugin specific tests here. Present so that CI is simpler and to avoid false plugin-specific tests passing.""" diff --git a/soda/impala/tests/test_impala_connection.py b/soda/impala/tests/test_impala_connection.py new file mode 100644 index 000000000..9f40cea02 --- /dev/null +++ b/soda/impala/tests/test_impala_connection.py @@ -0,0 +1,29 @@ +from textwrap import dedent + +from soda.scan import Scan + + +def test_invalid_impala_configs(): + scan = Scan() + scan.set_data_source_name("impalads") + scan.add_configuration_yaml_str( + dedent( + """ + data_source impalads: + type: impala + connection: + heist: localhost + """ + ).strip() + ) + scan.add_sodacl_yaml_str( + dedent( + """ + checks for CUSTOMERS: + - row_count > 0 + """ + ).strip() + ) + scan.execute() + + scan.assert_has_error('Could not connect to data source "impalads"') diff --git a/tbump.toml b/tbump.toml index 0b3f7dcd9..ad73956e2 100644 --- a/tbump.toml +++ b/tbump.toml @@ -109,3 +109,7 @@ search = 'package_version = "{current_version}"' [[file]] src = "soda/fabric/setup.py" search = 'package_version = "{current_version}"' + +[[file]] +src = "soda/impala/setup.py" +search = 'package_version = "{current_version}"' From 3d2ca98d4946365044c8cdd24be25253b50fb50d Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri, 13 Dec 2024 17:15:44 +0000 Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- soda/impala/soda/data_sources/impala_data_source.py | 10 +++------- soda/impala/tests/docker/config/hive-site.xml | 2 +- soda/impala/tests/impala_data_source_fixture.py | 8 ++++---- 3 files changed, 8 insertions(+), 12 deletions(-) diff --git a/soda/impala/soda/data_sources/impala_data_source.py b/soda/impala/soda/data_sources/impala_data_source.py index 4c720555b..c5f1f89b1 100644 --- a/soda/impala/soda/data_sources/impala_data_source.py +++ b/soda/impala/soda/data_sources/impala_data_source.py @@ -71,12 +71,10 @@ def connect(self): use_ssl=self.use_ssl, auth_mechanism=self.auth_mechanism, port=self.port, - database=self.database + database=self.database, ) else: - raise ConnectionError( - f"Invalid impala connection properties: invalid host: {self.host}" - ) + raise ConnectionError(f"Invalid impala connection properties: invalid host: {self.host}") return self.connection def safe_connection_data(self): @@ -107,9 +105,7 @@ def sql_find_table_names( return f"SHOW TABLES{from_clause}" def sql_get_table_names_with_count( - self, - include_tables: Union[list[str], None] = None, - exclude_tables: Union[list[str], None] = None + self, include_tables: Union[list[str], None] = None, exclude_tables: Union[list[str], None] = None ) -> str: return "" diff --git a/soda/impala/tests/docker/config/hive-site.xml b/soda/impala/tests/docker/config/hive-site.xml index 100fd9fc8..aa41bf58f 100644 --- a/soda/impala/tests/docker/config/hive-site.xml +++ b/soda/impala/tests/docker/config/hive-site.xml @@ -71,4 +71,4 @@ Hive configuration for Impala quickstart docker cluster. hive.stats.autogather false - \ No newline at end of file + diff --git a/soda/impala/tests/impala_data_source_fixture.py b/soda/impala/tests/impala_data_source_fixture.py index 0003a32e1..49abf801d 100644 --- a/soda/impala/tests/impala_data_source_fixture.py +++ b/soda/impala/tests/impala_data_source_fixture.py @@ -3,7 +3,7 @@ import logging import os -from helpers.data_source_fixture import DataSourceFixture, is_cicd +from helpers.data_source_fixture import DataSourceFixture logger = logging.getLogger(__name__) @@ -17,9 +17,9 @@ def _build_configuration_dict(self, schema_name: str | None = None) -> dict: "data_source impala": { "type": "impala", "host": os.getenv("IMPALA_HOST", "localhost"), - #"username": os.getenv("IMPALA_USERNAME", "impala"), - #"password": os.getenv("IMPALA_PASSWORD"), - #"database": os.getenv("IMPALA_DATABASE", "default"), + # "username": os.getenv("IMPALA_USERNAME", "impala"), + # "password": os.getenv("IMPALA_PASSWORD"), + # "database": os.getenv("IMPALA_DATABASE", "default"), "port": int(os.getenv("IMPALA_PORT", "21050")), "auth_mechanism": "NOSASL", }