Fix WHIP output #936
Merged
Fix WHIP output #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brzep
force-pushed
the
@brzep/whip-client-fix
branch
from
35b7dab to
33c4aeb
Compare
wkozyra95
approved these changes
Jan 29, 2025
| parameter: "pli".to_owned(), | ||
| }, | ||
| ]; | ||
| for codec in vec
There was a problem hiding this comment.
don't format loop like that, move that to variable or use iterator
I also don't think you need a vec there, it could be just a slice
brzep
force-pushed
the
@brzep/whip-client-fix
branch
from
33c4aeb to
36dfbb3
Compare
|
btw remember to update PR description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #923