Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some client_devnet tests to tests_on_networks #1480

Closed
franciszekjob opened this issue Sep 8, 2024 · 0 comments · Fixed by #1481
Closed

Move some client_devnet tests to tests_on_networks #1480

franciszekjob opened this issue Sep 8, 2024 · 0 comments · Fixed by #1481

Comments

@franciszekjob
Copy link
Collaborator

franciszekjob commented Sep 8, 2024 •
edited
Loading

Feature Request

Some devnet clients tests use network-related env variables. Due to it, Tests job will always fail when these variables are not set. client_devnet tests should be moved to tests_on_networks.
@franciszekjob franciszekjob mentioned this issue Sep 8, 2024
Merged
1 task
@franciszekjob franciszekjob changed the title Move client_devnet tests to tests_on_networks Move some client_devnet tests to tests_on_networks Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move test_impersonate_account test to tests_on_networks software-mansion/starknet.py
1 participant
@franciszekjob