Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JP] 07-routing/08-main.md not work #197

Open
ynishi opened this issue Apr 15, 2018 · 0 comments
Open

[JP] 07-routing/08-main.md not work #197

ynishi opened this issue Apr 15, 2018 · 0 comments

Comments

@ynishi
Copy link

ynishi commented Apr 15, 2018

Japanese 07-routing/08-main's code below has diff among others.
https://github.com/sporto/elm-tutorial/blob/master/jp/07-routing/08-main.md

init : Result String Route -> ( Model, Cmd Msg )
init result =
    let
        currentRoute =
            Routing.routeFromResult result
urlUpdate result model =
    let
        currentRoute =
            Routing.routeFromResult result

Japanse code use routeFromResult, but in Route section, it is not implemented.

It is good to change same as en-v01.
https://github.com/sporto/elm-tutorial/blob/master/en-v01/07-routing/08-main.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant