Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api version option not respected #32

Open
cameront opened this issue Jan 29, 2025 · 0 comments
Open

Api version option not respected #32

cameront opened this issue Jan 29, 2025 · 0 comments

Comments

@cameront
Copy link

if envValue := os.Getenv("VERSION"); envValue != "" {

It looks to me like even if I create a new client with &core.VersionOption{Version: "SOME_VER"}, at request time it will be overridden to either the version specified in code (currently 2025-01-23) or a version in a hard-coded VERSION env var.

Is this expected? I could see the rationale for locking down the version number since the request/response structs are likely specific to the 'current' api version, but why then provide the option to change it, and then not abide by it?

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant