Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The address of the bot comment does not contain the updated code. #235

Open
warmthsea opened this issue Sep 11, 2024 · 8 comments
Open

The address of the bot comment does not contain the updated code. #235

warmthsea opened this issue Sep 11, 2024 · 8 comments

Comments

@warmthsea
Copy link
Contributor

PR create bot commit:
warmthsea/element-plus#18 (comment)
(Does not include updated code)

PR update code:
https://github.com/warmthsea/element-plus/pull/18/checks?check_run_id=29967470452


Does the original comment address need to be updated?

@Aslemammad
Copy link
Member

Aslemammad commented Sep 11, 2024

Yep, the address of the pull request comment should not change since it addresses the latest commit of the PR always when you put the number of the PR there.

But the check run is what gets updated, when you visit the check run (commit: 3b1av3f) it contains the built package for that specific hash.

@warmthsea
Copy link
Contributor Author

Yep, the address of the pull request comment should not change since it addresses the latest commit of the PR always when you put the number of the PR there.

But the check run is what gets updated, when you visit the check run (commit: 3b1av3f) it contains the built package for that specific hash.

But when executing ↓, the installed build product is the original one, not the latest one. Is this by design?

(18 represents pr floor)

pnpm add https://pkg.pr.new/warmthsea/element-plus@18

@Aslemammad
Copy link
Member

I think this is because of caching!

Can you try adding the -f flag and let me know!

@warmthsea
Copy link
Contributor Author

warmthsea commented Sep 11, 2024

I think this is because of caching!

Can you try adding the -f flag and let me know!

Thank you very much for your reply. I have some doubts. Regarding whether the initial comment address of the installation is the latest code.

Info:

window 11
npm origin: https://registry.npmjs.org/ (default settings)
use pnpm version: 9.9.0
node version: v21.7.3
chrome、firefox

test pr: warmthsea/element-plus#20
test install repo: https://github.com/warmthsea/elp-pkg-pr-release-test


Step:

1、install pr Bot first commit link

pnpm add https://pkg.pr.new/warmthsea/element-plus@20

2、update warmthsea/element-plus components
3、wait for pkg.pr.new ci to complete
4、again install

pnpm add https://pkg.pr.new/warmthsea/element-plus@20

1、use Vercel deploy

  • execute in a short time (demo) (update content not effective)
  • execute in one minute (demo) (effective)

2、run locally (dev)

  • all time (not effective, I thinks it should take effect)

try:

  • delete pnpm-lock.yaml
  • again clone repo
  • delete node_modules
  • pnpm i xx --force

none of them took effect.

@Aslemammad
Copy link
Member

Hmm, but as I curl, it addresses the latest commit!

image

@thewilloftheshadow
Copy link

I'm also experiencing this issue with https://pkg.pr.new/buape/carbon/@buape/carbon@126. It shows the correct commit hash when curling it and I tried using --force as well, but it is still not actually downloading the PR's code, instead it's using main's code.

Here is the GitHub Action that I'm running: https://github.com/buape/carbon/blob/main/.github/workflows/ci.yml

@thewilloftheshadow
Copy link

I was able to confirm with buape/carbon#127 that it was using the code from main, as that changes PR does have main's code with the fixes for that version

@Aslemammad
Copy link
Member

As far as I remember, pull_request_target uses the main branch 🤔

So maybe that's the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants