Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (or rename) a LargeText component variant to explicitly support HTML elements #71

Open
KeziahMoselle opened this issue Sep 7, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@KeziahMoselle
Copy link
Member

Why

The name LargeText means it is supposed to only be used with text.
There is cases where we need to use this kind of animation for blocks elements and we are using this component to do so but the API of the component doesn't allow us to easily do what we want and requires overrides.

When used this way it also wraps blocs element in a <span> element, which is incorrect semantically.

<div {{ html_attributes(attributes) }}>
  <span {{ html_attributes(target_attributes) }}>
    {% for count in 1..repeat ?? 2 %}
      ...
    {% endfor %}
  </span>
</div>
@KeziahMoselle KeziahMoselle added the enhancement New feature or request label Sep 7, 2022
@KeziahMoselle KeziahMoselle self-assigned this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant