Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect size unit when logging fileUpload #1560

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

KulykDmytro
Copy link

fix size unit when logging fileUpload

closes #1559

Copy link

Thanks for the contribution! Before we can merge this, we need @KulykDmytro to sign the Salesforce Inc. Contributor License Agreement.

@KulykDmytro KulykDmytro changed the title Update fileuploads_endpoint.py Fix size unit when logging fileUpload Jan 21, 2025
@KulykDmytro
Copy link
Author

CLA signed, please proceed

@KulykDmytro KulykDmytro changed the title Fix size unit when logging fileUpload fix: incorrect size unit when logging fileUpload Jan 21, 2025
@KulykDmytro KulykDmytro changed the title fix: incorrect size unit when logging fileUpload Fixed incorrect size unit when logging fileUpload Jan 21, 2025
@jacalata jacalata changed the base branch from master to development January 22, 2025 01:34
Copy link
Contributor

@jacalata jacalata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@KulykDmytro
Copy link
Author

can we merge then?

@jacalata jacalata merged commit 1912806 into tableau:development Jan 22, 2025
21 checks passed
@KulykDmytro KulykDmytro deleted the patch-1 branch January 23, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect size stats showed when publishing datasource
2 participants