Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetDateTimeFormat: Don't override timeZoneName if already present #3064

Closed
anba opened this issue Dec 11, 2024 · 0 comments
Closed

GetDateTimeFormat: Don't override timeZoneName if already present #3064

anba opened this issue Dec 11, 2024 · 0 comments
Assignees
@ptomato
Labels
editorial spec-text Specification text involved

Comments

@anba
Copy link
Contributor

anba commented Dec 11, 2024

GetDateTimeFormat, step 17.c:

c. If defaults is zoned-date-time, then
    i. Set formatOptions.[[timeZoneName]] to "short".

This step shouldn't be executed when formatOptions.[[timeZoneName]] is already defined.
@ptomato ptomato added spec-text Specification text involved editorial labels Dec 12, 2024
@ptomato ptomato self-assigned this Jan 13, 2025
ptomato added a commit that referenced this issue Jan 14, 2025
@ptomato
Editorial: Don't override already existing timeZoneName in Intl options
a7997ce 
The intention here was to set a default, not override any existing value.
Thanks to Anba for spotting this.

Closes: #3064
ptomato added a commit that referenced this issue Jan 14, 2025
@ptomato
Editorial: Don't override already existing timeZoneName in Intl options
53577f7 
The intention here was to set a default, not override any existing value.
Thanks to Anba for spotting this.

Closes: #3064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptomato ptomato

Labels
editorial spec-text Specification text involved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ptomato @anba