Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference between documentation and implementation for SMAPE #8

Open
chris-fj opened this issue Jul 17, 2024 · 1 comment
Open

Difference between documentation and implementation for SMAPE #8

chris-fj opened this issue Jul 17, 2024 · 1 comment

Comments

@chris-fj
Copy link

chris-fj commented Jul 17, 2024

Hello, everyone

I was reviewing the SMAPE for v2.0 and I found something odd that may be a mistake in the documentation or a misunderstanding on my end.

The documentation uses the formula that includes the 2 in the numerator, which, according to this wikipedia page (that is linked into the docs), means that the SMAPE will range between 0 and 2 (or 0% and 200%). However, the docs specify that the SMAPE will range between 0 and 1, which is not totally wrong, because in the implementation (see here) one can see that the 2 is missing and as such, the SMAPE, as calculated by the library, will range between 0 and 1.

The issue here is that the docs shows one formula (the one whose results range 0 and 2) and implements the other one (the one whose results range between 0 and 1), which is a bit inconsistent. Maybe dropping the 2 from the formula will be the easiest solution, although it would be nice to be able to parametrize and have both metrics.

@thieu1995
Copy link
Owner

@chris-fj,

Thanks for pointing it out.
Basically, I took the commonly used equations as an actual implementation, but in my documentation, I forgot to remove the 2. I will remove it to fit the actual implementation code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants